Rename "Coordinate", "labeled" and "indexed"#161
Merged
shoyer merged 2 commits intopydata:masterfrom Jun 22, 2014
Merged
Conversation
Member
Author
|
Please speak up soon with any thoughts or I will just go ahead and merge this. I have updated the first post with a table of all name changes. I suspect the most controversial change here is @akleeman suggested keeping the property Another option would be |
Also renamed unselect to drop_vars. The logic behind these changes is that it would be really nice to have a short method for indexing by dimension name, since this is one of the most common operations one might do. Also, prefacing an indexing method with "i" nicely mirrors how pandas names its indexing methods/properties -- now it's clear that "sel" and "isel" are variants of each other. Fixes pydata#148.
shoyer
added a commit
that referenced
this pull request
Jun 22, 2014
Rename "Coordinate", "labeled" and "indexed"
shoyer
added a commit
to shoyer/xarray
that referenced
this pull request
Jul 10, 2014
Related pydata#142, pydata#161 Fixes pydata#178
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #142
Fixes #148
All existing code should still work but issue a
FutureWarningif any of the old names are used.Full list of updates:
CoordinateIndexcoordinatesindexesnoncoordinatesnonindexesindexedisellabeledselselectselect_varsunselectdrop_varsMost of these are both
DatasetandDataArraymethods/properties.