Simplify and restore old behavior for deep-copies #4453
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Intended to fix pydata#4449 Needs tests!
|
Great, this is simpler.
|
dcherian
reviewed
Sep 23, 2020
| @@ -2432,42 +2437,6 @@ def concat(cls, variables, dim="concat_dim", positions=None, shortcut=False): | |||
|
|
|||
| return cls(first_var.dims, data, attrs) | |||
|
|
|||
| def copy(self, deep=True, data=None): | |||
There was a problem hiding this comment.
shall we keep this but use self.__copy__ under the hood?
It lines up well with Dataset.copy() and DataArray.copy()
|
Hello @shoyer! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
|
|
I believe this is no longer an issue. Please re-open if there's more to do here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Intended to fix #4449
The goal is to restore behavior to match what we had prior to #4379 for all types of
dataother thannp.ndarrayobjectsNeeds tests!
isort . && black . && mypy . && flake8whats-new.rstapi.rst