-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Increase visibility of allowed failures #4584
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increase visibility of allowed failures #4584
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
It seems we can set the result to "succeeded with issues", which works pretty well in the pipeline overview. However, the only difference this makes on github is that it prints the result in the checks tab – no fancy icon, github seems to only know the We also need to decide whether to set Edit: before merging I still need to remove the intentionally failing test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for figuring this out. Re the upstream-dev
- I think if #4583 works as it should we could also allow failures for the upstream dev.
Co-authored-by: Mathias Hauser <[email protected]>
if we agree on keeping the |
Great! Definitely LGTM! |
cc0e74f
to
ebb8c40
Compare
should we merge this? I think we can decide which CI to keep (pipelines or github actions) in a different PR / issue |
we have two votes agreeing with me, so let's merge! |
Right now, allowed failures are hard to see, so this tries to add warnings to increase the visibility without removing the
allow_failure
flag.