Skip to content

Increase visibility of allowed failures #4584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Dec 7, 2020
Merged

Increase visibility of allowed failures #4584

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
5e89308
try to warn on allowed failure
keewis Nov 14, 2020
03073bd
allow failures on upstream-dev
keewis Nov 14, 2020
96a6e1d
install pynio to intentionally fail the upstream-dev CI
keewis Nov 14, 2020
bfc1827
install pynio before uninstalling other packages
keewis Nov 14, 2020
553a5e6
fail a flaky test instead of installing a incompatible library
keewis Nov 14, 2020
904feef
try changing to error
keewis Nov 14, 2020
131c357
try setting the result
keewis Nov 14, 2020
8ca4627
Update ci/azure/unit-tests.yml
keewis Nov 17, 2020
ca3b36f
remove the intentionally failed test
keewis Nov 18, 2020
bc71825
don't use the escape code for '#'
keewis Nov 21, 2020
b8d2163
Merge branch 'master' into increase-visibility-of-allowed-failures
keewis Nov 23, 2020
ebb8c40
Merge branch 'master' into increase-visibility-of-allowed-failures
keewis Dec 6, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions azure-pipelines.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ jobs:
py38-upstream-dev:
conda_env: py38
upstream_dev: true
allow_failure: true
py38-flaky:
conda_env: py38
pytest_extra_flags: --run-flaky --run-network-tests
Expand Down
7 changes: 6 additions & 1 deletion ci/azure/unit-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,12 @@ steps:
--junitxml=junit/test-results.xml \
--cov=xarray \
--cov-report=xml \
$(pytest_extra_flags) || [ "$ALLOW_FAILURE" = "true" ]
$(pytest_extra_flags) \
|| ( \
[ "$ALLOW_FAILURE" = "true" ] \
&& echo -e "\043#vso[task.logissue type=warning]Ignored CI failure!!" \
&& echo -e "\043#vso[task.complete result=SucceededWithIssues]" \
)
displayName: Run tests

- bash: |
Expand Down
3 changes: 3 additions & 0 deletions xarray/tests/test_tutorial.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,3 +30,6 @@ def test_download_from_github_load_without_cache(self):
ds_nocache = tutorial.open_dataset(self.testfile, cache=False).load()
ds_cache = tutorial.open_dataset(self.testfile).load()
assert_identical(ds_cache, ds_nocache)

def test_failing(self):
assert False