Image glitch when loading and immediately rotating a surface.

[SamuelWyck]

WIth pygame-ce 2.5.4 loading an image, immediately rotating it, and then convert_alpha, the surface returned is completely white.

basic_enemy_img = pygame.transform.rotate(pygame.image.load(
    os.path.join("Assets/Enemy_assets", "basic_enemy.png")), 180).convert_alpha()

The code above worked just fine in 2.5.3 but as I said above, in pygame-ce 2.5.4 it returns a completely white surface.
I was able to fix the issue with the code below, (converting the surface before rotating) but I'm pretty sure this behaviour is not intended.

basic_enemy_img = pygame.transform.rotate(pygame.image.load(
    os.path.join("Assets/Enemy_assets", "basic_enemy.png")).convert_alpha(), 180)

[oddbookworm]

I've confirmed that this is the behavior I see as well. Minimum example using the "alien1.png" provided in the examples directory of pygame:

MRE

import pygame

pygame.display.set_mode((500, 500))

basic_enemy_img = pygame.transform.rotate(pygame.image.load("alien1.png"), 180).convert_alpha()

pygame.image.save(basic_enemy_img, "output.png")

[oddbookworm]

I've bisected the commits
this merge commit is fine
this merge commit, which was the next merge, is broken

Issue opened for another thing I potentially pegged on the same merge: #3370

[Starbuck5]

Thank you for the bug report SamuelWyck, thank you for investigating and fixing so quickly Andrew.

With the code in mind, this bug is "pygame.transform functions fail to apply palette data to output surfaces"

Specifically these functions should be impacted (not fully checked)-- average_surfaces, box_blur, chop, flip, gaussian_blur, grayscale, hsl, invert, laplacian, rotate, rotozoom, scale, scale2x, scale_by, solid_overlay, threshold

[Starbuck5]

Fix for this is included in pygame-ce 2.5.5, which has just been released.