Fix palettes in newsurf_fromsurf
#3464
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-community#3314 to fix pygame-community#3463 and added regression test
|
Also fixes #2354 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3314 had an uncaught issue that means
newsurf_fromsurfinstantiates palettes incorrectly, causing .... white. I reported this before when I was trying to revive #2354, but I could only point to the specific PR that broke it. Now that #3463 has been opened, I investigated further and finally found the source of the problem. I haven't tested it on mypixelateproblem, but I suspect this is the cause there as well because it's the same symptomCloses #3463 and should also close #3370, but I'll verify that one manually at a later date