Skip to content

Reducing the running time of tests #3823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 5, 2020
Merged

Reducing the running time of tests #3823

merged 1 commit into from
Mar 5, 2020

Conversation

sleepy-owl
Copy link

Hi,

I updated the number of samples in test_t in test_distributions.py which reduces the running time of the test from ~59s to ~19s on my local machine. I also verified that the test passes on multiple seeds.

Would you guys be interested in such optimizations? If yes, I can help contribute more and look at how to optimize other expensive tests in the test suite. Please let me know if you have any other suggestions or any necessary checks that I should do on these tests.

Thanks!

Updating number of samples
@codecov
Copy link

codecov bot commented Mar 4, 2020

Codecov Report

Merging #3823 into master will increase coverage by 0.31%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3823      +/-   ##
==========================================
+ Coverage   90.45%   90.76%   +0.31%     
==========================================
  Files         133      133              
  Lines       20566    20566              
==========================================
+ Hits        18603    18667      +64     
+ Misses       1963     1899      -64     
Impacted Files Coverage Δ
pymc3/distributions/continuous.py 80.85% <0.00%> (+0.40%) ⬆️
pymc3/tests/test_mixture.py 99.65% <0.00%> (+0.69%) ⬆️
pymc3/step_methods/hmc/base_hmc.py 95.32% <0.00%> (+0.93%) ⬆️
pymc3/tests/test_transforms.py 100.00% <0.00%> (+1.47%) ⬆️
pymc3/tests/test_distributions.py 98.14% <0.00%> (+1.72%) ⬆️
pymc3/tests/test_step.py 100.00% <0.00%> (+6.79%) ⬆️
pymc3/tests/models.py 85.95% <0.00%> (+15.70%) ⬆️

@twiecki
Copy link
Member

twiecki commented Mar 5, 2020

@sleepy-owl Definitely, thanks!

@twiecki twiecki merged commit 49abe3f into pymc-devs:master Mar 5, 2020
@sleepy-owl sleepy-owl mentioned this pull request Mar 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants