Reduce number of test points in slow logcdf methods #4459
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CI tests for logcdf methods that make use of
dist_math.incomplete_beta::incomplete_beta
are crazy slow. This is reported in #4420This PR simply reduces the number of random tested points, which could save up to an hour in the CIs. Note that a similar change was already done for the logcdf method of the StudentT in #3823 for the same reasons.
Besides, these methods have passed many times now without failures, so it should be okay to reduce the number of points in each run. Objections?
Depending on what your PR does, here are a few things you might want to address in the description: