Update more samplers for v4 compatibility #4559
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| while y <= logp(ql): # changed lt to leq for locally uniform posteriors | ||
| while y <= logp( | ||
| RaveledVars(ql, q0.point_map_info) | ||
| ): # changed lt to leq for locally uniform posteriors |
There was a problem hiding this comment.
The line is split by black only because of the comment (compare next while). The comment should probably go on its own line above..
brandonwillard
force-pushed
the
update-samplers
branch
3 times, most recently
from
1ce73c3 to
b171224
Compare
ricardoV94
reviewed
Mar 24, 2021
brandonwillard
force-pushed
the
update-samplers
branch
from
5e22dab to
0968539
Compare
|
@ricardoV94, once these tests pass, I'll merge this and help out with #4548 (e.g. it will need to be rebased, etc.) |
brandonwillard
force-pushed
the
update-samplers
branch
2 times, most recently
from
8da59fe to
5fa3572
Compare
brandonwillard
force-pushed
the
update-samplers
branch
from
5fa3572 to
02f8c3a
Compare
brandonwillard
force-pushed
the
update-samplers
branch
from
02f8c3a to
dddd6d2
Compare
brandonwillard
force-pushed
the
update-samplers
branch
from
dddd6d2 to
1414e97
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the changes necessary to run more step methods in v4 (e.g. basic Metropolis, slice sampler, etc.)