Skip to content

Don't change constant names in Features #348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 16, 2023

Conversation

ricardoV94
Copy link
Member

@ricardoV94 ricardoV94 commented Jun 16, 2023

Closes #347

@codecov-commenter
Copy link

codecov-commenter commented Jun 16, 2023

Codecov Report

Merging #348 (b30b52d) into main (f4536c3) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #348      +/-   ##
==========================================
- Coverage   80.40%   80.40%   -0.01%     
==========================================
  Files         156      156              
  Lines       45416    45415       -1     
  Branches    11114    11114              
==========================================
- Hits        36515    36514       -1     
  Misses       6695     6695              
  Partials     2206     2206              
Impacted Files Coverage Δ
pytensor/graph/rewriting/basic.py 64.22% <ø> (-0.05%) ⬇️
pytensor/graph/features.py 65.31% <100.00%> (ø)
pytensor/scalar/basic.py 80.24% <100.00%> (+<0.01%) ⬆️

@ricardoV94 ricardoV94 marked this pull request as ready for review June 16, 2023 12:34
@ricardoV94 ricardoV94 changed the title Don't change constant names Don't allow MergeFeature to change constant names Jun 16, 2023
@ricardoV94 ricardoV94 added the bug Something isn't working label Jun 16, 2023
@ricardoV94 ricardoV94 force-pushed the dont_change_constants_names branch from 77659c4 to 0add68f Compare June 16, 2023 12:37
…graph C code of Composite

Otherwise, it will show up everytime a Composite has been cached by th C backend
@ricardoV94 ricardoV94 force-pushed the dont_change_constants_names branch from 0add68f to b30b52d Compare June 16, 2023 13:34
@ricardoV94 ricardoV94 changed the title Don't allow MergeFeature to change constant names Don't change constant names in Features Jun 16, 2023
@michaelosthege michaelosthege merged commit b9c4f20 into pymc-devs:main Jun 16, 2023
@ricardoV94 ricardoV94 deleted the dont_change_constants_names branch June 21, 2023 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Evaluating graph changes constants in place
3 participants