Evaluating graph changes constants in place

[ricardoV94]

Description

import pytensor.tensor as pt

x = pt.as_tensor(0)
x.name = "x"

y = pt.as_tensor(0)
y.name = "y"

assert y.name == "y"
assert x.name == "x"  # raises

(x + y).eval()

assert y.name == "y"
assert x.name == "x"  # raises

[ricardoV94]

Seems to be caused by the MergeFeature here:

pytensor/pytensor/graph/rewriting/basic.py

Lines 593 to 594 in 1da2891

	if c.name:
	other_c.name = c.name