-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Add ExGaussian moment #5165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ExGaussian moment #5165
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for opening the PR! I left some comments below
@karm216 Thanks -- some conflicts left to resolve. |
Codecov Report
@@ Coverage Diff @@
## main #5165 +/- ##
=======================================
Coverage 78.08% 78.09%
=======================================
Files 88 88
Lines 14143 14149 +6
=======================================
+ Hits 11043 11049 +6
Misses 3100 3100
|
Hi @ricardoV94, Can you please check if everything is fine? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. Waiting to see if tests pass
Thank you for accepting PR :) |
Add moment and tests for the below distribution as part of #5078
pymc.distributions.continuous.ExGaussian