Skip to content

Add ExGaussian moment #5165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Nov 11, 2021
Merged

Add ExGaussian moment #5165

merged 11 commits into from
Nov 11, 2021

Conversation

karm-patel
Copy link
Contributor

@karm-patel karm-patel commented Nov 9, 2021

Add moment and tests for the below distribution as part of #5078

pymc.distributions.continuous.ExGaussian

@ricardoV94 ricardoV94 mentioned this pull request Nov 9, 2021
51 tasks
Copy link
Member

@ricardoV94 ricardoV94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening the PR! I left some comments below

@twiecki
Copy link
Member

twiecki commented Nov 10, 2021

@karm216 Thanks -- some conflicts left to resolve.

@codecov
Copy link

codecov bot commented Nov 10, 2021

Codecov Report

Merging #5165 (7af05d0) into main (5dacdae) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #5165   +/-   ##
=======================================
  Coverage   78.08%   78.09%           
=======================================
  Files          88       88           
  Lines       14143    14149    +6     
=======================================
+ Hits        11043    11049    +6     
  Misses       3100     3100           
Impacted Files Coverage Δ
pymc/distributions/continuous.py 96.38% <100.00%> (+0.02%) ⬆️

@karm-patel
Copy link
Contributor Author

Hi @ricardoV94, Can you please check if everything is fine?

Copy link
Member

@ricardoV94 ricardoV94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Waiting to see if tests pass

@ricardoV94 ricardoV94 merged commit 275c145 into pymc-devs:main Nov 11, 2021
@karm-patel
Copy link
Contributor Author

Thank you for accepting PR :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants