Skip to content

Fix make_initial_point_expression recursion bug #5170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 12, 2021
Merged

Fix make_initial_point_expression recursion bug #5170

merged 1 commit into from
Nov 12, 2021

Conversation

ricardoV94
Copy link
Member

Fixes #5168

@codecov
Copy link

codecov bot commented Nov 11, 2021 •
edited
Loading

Codecov Report

Merging #5170 (dd1c8c0) into main (275c145) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5170      +/-   ##
==========================================
- Coverage   78.09%   78.08%   -0.02%     
==========================================
  Files          88       88              
  Lines       14149    14145       -4     
==========================================
- Hits        11050    11045       -5     
- Misses       3099     3100       +1
Impacted Files Coverage Δ
pymc/initial_point.py 100.00% <100.00%> (ø)
pymc/bart/pgbart.py 96.24% <0.00%> (-0.38%) ⬇️

@ricardoV94 ricardoV94 mentioned this pull request Nov 11, 2021
Open
@ricardoV94
Copy link
Member Author

All failing tests seem attributable to aesara-devs/aeppl#91

@michaelosthege michaelosthege mentioned this pull request Nov 11, 2021
Closed
@pymc-devs pymc-devs deleted a comment from michaelosthege Nov 11, 2021
michaelosthege
michaelosthege reviewed Nov 11, 2021
View reviewed changes
Copy link
Member

@michaelosthege michaelosthege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One thing to improve test code readibility.. Other than that I'm looking forward to the fix.

@ricardoV94 ricardoV94 force-pushed the fix_initval_recursion_bug branch from e438f06 to 2f4291a Compare November 12, 2021 16:40
@ricardoV94 ricardoV94 force-pushed the fix_initval_recursion_bug branch from 2f4291a to dd1c8c0 Compare November 12, 2021 16:45
@ricardoV94 ricardoV94 merged commit fd7fc60 into pymc-devs:main Nov 12, 2021
@ricardoV94 ricardoV94 deleted the fix_initval_recursion_bug branch November 15, 2021 14:47
@ricardoV94 ricardoV94 mentioned this pull request Nov 15, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelosthege michaelosthege michaelosthege approved these changes

@aseyboldt aseyboldt Awaiting requested review from aseyboldt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Recursion problems in make_initial_point_expression
2 participants
@ricardoV94 @michaelosthege