-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Adding check to prevent mixing of discrete and continuous distributions #5629
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding check to prevent mixing of discrete and continuous distributions #5629
Conversation
Codecov Report
@@ Coverage Diff @@
## main #5629 +/- ##
==========================================
+ Coverage 88.82% 88.86% +0.04%
==========================================
Files 75 75
Lines 13736 13737 +1
==========================================
+ Hits 12201 12208 +7
+ Misses 1535 1529 -6
|
Always! |
Can you share a quick pointer on how to catch errors? |
Usually with There are a bunch of examples in the codebase, here is just a random one: pymc/pymc/tests/test_aesaraf.py Lines 60 to 61 in 8b063f9
|
cd58d41
to
c69b0c5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. I left some minor suggestions
0d55366
to
2ec6c80
Compare
Awesome, thanks! |
Closes #4511.
all_discrete
inmixture.py
has also been removedIs there a test that should be added?