Wrap sigma parameter with as_tensor_variable() before get_tau_sigma() - #6745
Closed
enessinanparildi wants to merge 1 commit into
Closed
Wrap sigma parameter with as_tensor_variable() before get_tau_sigma()#6745enessinanparildi wants to merge 1 commit into
enessinanparildi wants to merge 1 commit into
Conversation
For the cases where the sigma parameter is a vector of random variables instead of fixed values, in get_tau_sigma if np.any(sigma_ <= 0) throws the following error: TypeError: Variables do not support boolean operations. Sigma parameter normally is wrapped by as_tensor_variable() after get_tau_sigma. Moving the line sigma= pt.as_tensor_variable(sigma) before get_tau_sigma() resolves this issue.
|
|
Member
|
That will avoid the negative check every time. I think we can remove the check because I don't think users would ever pass non symbolic negative sigmas. If they do, the new |
Member
|
Closing in favor of #6988 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

For the cases where the sigma parameter is a vector of random variables instead of fixed values, in get_tau_sigma
if np.any(sigma_ <= 0)throws the following error: TypeError: Variables do not support boolean operations.Sigma parameter normally is wrapped by as_tensor_variable() after get_tau_sigma. Moving the line
sigma= pt.as_tensor_variable(sigma)before get_tau_sigma() resolves this issue. I ran some tests by supplying sigma argument with different types of values. They are all fine.Bugfixes
if np.any(sigma_ <= 0)throws the following error: TypeError: Variables do not support boolean operations.📚 Documentation preview 📚: https://pymc--6745.org.readthedocs.build/en/6745/