Refactor get_tau_sigma and support lists of variables - #6988
Closed
tvwenger wants to merge 0 commit into
Closed
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6988 +/- ##
===========================================
- Coverage 89.60% 77.73% -11.88%
===========================================
Files 100 100
Lines 16888 16880 -8
===========================================
- Hits 15133 13121 -2012
- Misses 1755 3759 +2004
|
Member
|
@tvwenger would you like to update this PR? Would only need to add some regression tests for the original issue |
Contributor
Author
|
@ricardoV94 Thanks for the reminder and sorry for the delay. I added some regression tests, so this should be good to go once the checks are finished. |
Contributor
Author
|
@ricardoV94 This PR is ready for review |
ricardoV94
approved these changes
Mar 4, 2024
Contributor
Author
|
@ricardoV94 Ready for review when checks are done |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR about?
This PR refactors the
get_tau_sigmalogic in order to support lists ofVariables and fixes #6987.N.B. The original code had a positivity check for non-
Variablearguments, but not forVariablearguments. Since this PR casts the arguments toVariable, I've removed the positivity check for non-Variablearguments.Checklist
Major / Breaking Changes
get_tau_sigmanow always returns aVariable, even when scalars are passedNew features
Bugfixes
get_tau_sigmadoes not support list of variables #6987Documentation
Maintenance
📚 Documentation preview 📚: https://pymc--6988.org.readthedocs.build/en/6988/