-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Refactor get_tau_sigma
and support lists of variables
#6988
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6988 +/- ##
===========================================
- Coverage 89.60% 77.73% -11.88%
===========================================
Files 100 100
Lines 16888 16880 -8
===========================================
- Hits 15133 13121 -2012
- Misses 1755 3759 +2004
|
@tvwenger would you like to update this PR? Would only need to add some regression tests for the original issue |
@ricardoV94 Thanks for the reminder and sorry for the delay. I added some regression tests, so this should be good to go once the checks are finished. |
@ricardoV94 This PR is ready for review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good, just two nitpicks, one of which is not related to your changes. Let me know if you want me to merge or if you want to address them.
@ricardoV94 Ready for review when checks are done |
What is this PR about?
This PR refactors the
get_tau_sigma
logic in order to support lists ofVariable
s and fixes #6987.N.B. The original code had a positivity check for non-
Variable
arguments, but not forVariable
arguments. Since this PR casts the arguments toVariable
, I've removed the positivity check for non-Variable
arguments.Checklist
Major / Breaking Changes
get_tau_sigma
now always returns aVariable
, even when scalars are passedNew features
Bugfixes
get_tau_sigma
does not support list of variables #6987Documentation
Maintenance
📚 Documentation preview 📚: https://pymc--6988.org.readthedocs.build/en/6988/