-
Notifications
You must be signed in to change notification settings - Fork 129
Fix E721: do not compare types, for exact checks use is / is not #596
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #596 +/- ##
=======================================
Coverage 80.83% 80.83%
=======================================
Files 163 163
Lines 46897 46897
Branches 11468 11468
=======================================
Hits 37910 37910
Misses 6774 6774
Partials 2213 2213
|
I think we can go ahead with this one @maresb Can you rebase? |
@ricardoV94, rebase is complete. |
@maresb were we suppressing this pre-commit rule, should we reactivate it? |
No we weren't, it's just totally broken in Ruff: astral-sh/ruff#6465 But now E721 passes with flake8 |
Description
This splits out a controvertial part of #581 code cleanup. See #581 (comment).
This runs a risk of breaking something extremely subtle, so I think we will not want to merge this, but I wanted to at least give this its own PR number for reference.
Checklist
Type of change