Update pre-commit hooks

[maresb]

@ricardoV94, for a more sustainable solution I think we should install https://github.com/marketplace/pre-commit-ci

Description

Related Issue

• Closes #
• Related to #

Checklist

• Checked that the pre-commit linting/style checks pass
• Included tests that prove the fix is effective or that the new feature works
• Added necessary documentation (docstrings and/or example notebooks)
• If you are a pro: each commit corresponds to a relevant logical change

Type of change

• New feature / enhancement
• Bug fix
• Documentation
• Maintenance
• Other (please specify):

[ricardoV94]

@ricardoV94, for a more sustainable solution I think we should install https://github.com/marketplace/pre-commit-ci

I trust you there. Just have to remember to disable our dependency update bot then?

[ricardoV94]

@maresb wanna do it in this PR already?

[codecov-commenter]

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (c5b96d9) 80.92% compared to head (a66b277) 80.92%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #581      +/-   ##
==========================================
- Coverage   80.92%   80.92%   -0.01%     
==========================================
  Files         162      162              
  Lines       46641    46648       +7     
  Branches    11399    11395       -4     
==========================================
+ Hits        37746    37749       +3     
- Misses       6667     6670       +3     
- Partials     2228     2229       +1     

Files	Coverage Δ
pytensor/compile/debugmode.py	61.46% <100.00%> (ø)
pytensor/compile/ops.py	83.57% <100.00%> (ø)
pytensor/compile/profiling.py	76.19% <100.00%> (ø)
pytensor/graph/rewriting/unify.py	99.34% <100.00%> (ø)
pytensor/ifelse.py	51.70% <100.00%> (ø)
pytensor/link/c/params_type.py	80.41% <ø> (ø)
pytensor/link/c/type.py	75.98% <ø> (ø)
pytensor/link/utils.py	59.69% <100.00%> (ø)
pytensor/scalar/math.py	87.79% <100.00%> (ø)
pytensor/scan/op.py	84.71% <100.00%> (ø)
... and 13 more

[ricardoV94]

Is this surely equivalent? Could the classes override type equality somehow?

The many places where we had type(...) == type(...) make me weary of these changes.

[maresb]

Ya, I am also weary of this commit. You should be very skeptical.

On my first attempt I also changed this line and it caused a test failure. (Note that this line is not like the others: .type instead of type(), and doesn't lead to a warning; I was just replacing == with is wherever I saw it next to type.)

[ricardoV94]

Yeah that's different. Is there a reference for this rule that we can look at? Maybe that will confirm it is indeed always safe to do so.

[maresb]

This has been largely superseded by #586.

I split the code changes into #598, #597, and #596.

I'm going to open a fresh PR with hopefully just a pure pre-commit autoupgrade.