Skip to content

Conversation

maresb
Copy link
Contributor

@maresb maresb commented Jan 15, 2024

Description

In the course of #586 we observed that newer versions of pyupgrade (the current latest 3.15.0 vs the outdated 3.3.1 configured in .pre-commit-config.yaml) caught a few more issues that ruff missed. I'm not sure why; perhaps pyupgrade is more up-to-date than ruff.

We can merge these particular fixes, but it's probably worth considering what to do here in general. Like should we still run pyupgrade, and perhaps also flake8 in the CI to ensure that ruff isn't missing stuff?

Related Issue

  • Closes #
  • Related to #

Checklist

Type of change

  • New feature / enhancement
  • Bug fix
  • Documentation
  • Maintenance
  • Other (please specify):

This was referenced Jan 15, 2024
@maresb
Copy link
Contributor Author

maresb commented Jan 15, 2024

Not sure why coverage is failing, but it looks like a remote failure instead of something from our side.

@maresb maresb requested a review from ricardoV94 January 15, 2024 14:53
@ricardoV94
Copy link
Member

Not sure why coverage is failing, but it looks like a remote failure instead of something from our side.

Yeah, let's keep an eye in the near term

@ricardoV94 ricardoV94 merged commit 5c4c6b5 into pymc-devs:main Jan 15, 2024
@maresb maresb deleted the pyupgrade-fixes branch January 15, 2024 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants