Make error message (for missing verified email) work with Test PyPI #3184
Labels
APIs/feeds
feature request
good first issue
This issue is ideal for first-time contributors!
help needed
We'd love volunteers to advise on or help fix/implement this.
testing
Test infrastructure and individual tests
Milestone
Right now, when someone tries to upload a package to PyPI but does not have a verified email address on file, the error message we send them includes -- hardcoded -- the URL https://pypi.org. Instead, we should use Pyramid's URL routing to refer to the URL of the PyPI in question, thus ensuring that we send error messages that, as appropriate, refer to pypi.org, test.pypi.org, or any other future PyPI.
To fix this, look at
warehouse/forklift/legacy.py
andtests/unit/forklift/test_legacy.py
(the test istest_upload_requires_verified_email
), and make changes similar to the changes I made in #3183. If you're used to string substitution/string formatting in Python, this should be a pretty approachable first Warehouse issue.Good First Issue: This issue is good for first time contributors. If you've already contributed to Warehouse, please work on another issue without this label instead. If there is not a corresponding pull request for this issue, it is up for grabs. For directions for getting set up, see our Getting Started Guide. If you are working on this issue and have questions, please feel free to ask them here,
#pypa-dev
on Freenode, or the pypa-dev mailing list.The text was updated successfully, but these errors were encountered: