Rename color variables #3448
Rename color variables #3448
Conversation
|
Thanks @nitinprakash96 - #3433 is now merged - the changes in that PR will affect this PR, so you will need to update your branch with master. Because of this update , we now also have Another thing which would be helpful - if you could add "Closes #3435" to the top of your pull request, when we merge it, it will automatically close the corresponding issue. Thanks for your help on this! |
nitinprakash96
force-pushed
the
rename-color-variables
branch
from
029999d to
0bd5927
Compare
|
Hi, @nitinprakash96! Thanks for updating this! I presume it's now ready to re-review. :) @waseem18 could you give this a look when you have a chance? |
| $brand-color-soft: lighten($brand-color, 45); | ||
| $brand-color-dark: darken($brand-color, 10); | ||
| $primary-color-light: lighten($primary-color, 45); | ||
| $primary-color-dark: darken($primary-color, 10); | ||
|
|
There was a problem hiding this comment.
could we please check / fix the indentation here? thanks :)
|
Other than a small indentation issue, the code looks good to me. @waseem18 if you could double check we've not missed anything and that all styles are building as expected, that would be great! Thanks |
|
LGTM as well 👍 |
| $brand-color: #006dad; | ||
| $primary-color: #ffd343; | ||
| $primary-color: #006dad; | ||
| $highlight-color: #ffd343; |
There was a problem hiding this comment.
There still appears to be an indentation issue here. All variables should line up. Check that you're not using tabs rather than spaces :)
Previously we sorted by submitted_date, which was troublesome as many JournalEntry objects may be committed in a single transaction, leading to identical timestamps. SQLAlchemy retains the order of jounal creation, and flushes in order so ordering by submitted_date, id is deterministic and represents the logical order of operations. Closes pypi#3474, thanks to @anowlcalledjosh for reporting
* Add FAQ entry about requesting new Trove classifiers * Add issue template
nitinprakash96
force-pushed
the
rename-color-variables
branch
from
3505a1a to
085f9f8
Compare
|
Sorry about the commit messages. I somehow messed up the branch confusing it with another. I'll fix them soon. |
|
hi @nitinprakash96 - no need to clean up your commit history. We can squash the commits when we merge :) This all looks good to me - are you happy for me to merge? |
|
@nlhkabu its all good to go then. :) |
|
Thank you @nitinprakash96 ! |
|
@nitinprakash96 Thanks! Let us know if you'd like a suggestion for another issue to work on! |
|
@brainwane I'd love to start with some other issue. Could you suggest me some? It'd be gre |
|
@nitinprakash96 Take a look at #3184? Comment there if you want to try working on it. :) |
closes #3435