Skip to content

Add warning banner #3433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 28, 2018
Merged

Add warning banner #3433

merged 2 commits into from
Mar 28, 2018

Conversation

nlhkabu
Copy link
Contributor

@nlhkabu nlhkabu commented Mar 27, 2018

Closes #3426

screenshot from 2018-03-27 06-08-35

@nlhkabu nlhkabu requested a review from brainwane March 27, 2018 05:11
@nlhkabu
Copy link
Contributor Author

nlhkabu commented Mar 27, 2018

To affect this change on the beta banner, we will need to update pypi-theme. PR here: https://github.com/python/pypi-theme/pull/24

@nlhkabu nlhkabu requested review from ewdurbin and di and removed request for brainwane March 28, 2018 04:27
@nlhkabu
Copy link
Contributor Author

nlhkabu commented Mar 28, 2018

@ewdurbin or @di - any chance of a review on this? It's blocking a PR from a new contributor.

@ewdurbin
Copy link
Member

Not clear to me why the tests are failing. Seems the frontend build is failing on travis:

Error in plugin 'sass'
Message:
    warehouse/static/sass/blocks/_notification-bar.scss
Error: Undefined variable: "$brand-color-dark".
        on line 40 of warehouse/static/sass/blocks/_notification-bar.scss
        from line 90 of warehouse/static/sass/warehouse.scss
>>   background-color: $brand-color-dark;

@nlhkabu nlhkabu force-pushed the warning-notification branch from 44d50d4 to 05f0ae2 Compare March 28, 2018 17:33
@nlhkabu nlhkabu merged commit 84086f9 into master Mar 28, 2018
@nlhkabu nlhkabu deleted the warning-notification branch March 29, 2018 04:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants