Skip to content

Rename color variables to make more sense #3435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
nlhkabu opened this issue Mar 27, 2018 · 2 comments · Fixed by #3448
Closed

Rename color variables to make more sense #3435

nlhkabu opened this issue Mar 27, 2018 · 2 comments · Fixed by #3448
Labels
CSS/SCSS requires change to CSS/SCSS files good first issue This issue is ideal for first-time contributors!

Comments

@nlhkabu
Copy link
Contributor

nlhkabu commented Mar 27, 2018 •
edited
Loading

To be done after #3433 is merged.

  1. Rename primary-color to highlight-color
  2. Rename brand-color to primary-color
  3. Rename brand-color-soft to primary-color-light

Good First Issue: This issue is good for first time contributors. If you've already contributed to Warehouse, please work on another issue without this label instead. If there is not a corresponding pull request for this issue, it is up for grabs. For directions for getting set up, see our Getting Started Guide. If you are working on this issue and have questions, please feel free to ask them here, #pypa-dev on Freenode, or the pypa-dev mailing list.
@nlhkabu nlhkabu added good first issue This issue is ideal for first-time contributors! CSS/SCSS requires change to CSS/SCSS files labels Mar 27, 2018
@nitinprakash96
Copy link
Contributor

I'd like to work on this one.

@brainwane
Copy link
Contributor

@nitinprakash96 Please go ahead! Let us know how it's going.

@nlhkabu nlhkabu mentioned this issue Mar 28, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CSS/SCSS requires change to CSS/SCSS files good first issue This issue is ideal for first-time contributors!
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rename color variables nitinprakash96/warehouse
3 participants
@brainwane @nlhkabu @nitinprakash96