Make two upload tests URL-independent #3183
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It was reasonably mechanical to make these changes, so if we approve this, I'll set up new Good First Issue bug reports to fix |
brainwane
force-pushed
the
api-errors-route-url
branch
from
4bf631d to
66ead2d
Compare
|
👍 to the good first issues. |
Mariatta
pushed a commit
to Mariatta/warehouse
that referenced
this pull request
Mar 9, 2018
* Make permissions check upload test URL-independent * Make standard library collision name check URL-independent
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to #3175. Change the upload permissions check and project name/Python standard library collision check error messages refer to the URL of the PyPI in question, thus ensuring that we send error messages that, as appropriate, refer to pypi.org, test.pypi.org, or any other future PyPI.