Skip to content

pyrefly report should include private names listed in __all__ #3578

Closed

Description

@jorenham

Using a leading _ to indicate a private name is but a convention, not a hard rule. So if a project explicitly lists such a "private" name in the __all__, then I think it's reasonable to assume that it's intended to be part of the public API. Because of that, I think it should then also be treated as such in pyrefly coverage reports.

I don't have a concrete example of this, but I saw in the code that "private" names are currently always skipped.

Metadata

Metadata

Assignees

No one assigned

    Labels

    coverageIssues related to `pyrefly coverage`quansight

    Type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions