Skip to content

Include private names from __all__ in pyrefly coverage report - #3580

Closed
jorenham wants to merge 1 commit into
pyrefly-org:mainfrom
jorenham:gh-3578
Closed

jorenham wants to merge 1 commit into
pyrefly-org:mainfrom
jorenham:gh-3578

Conversation

@jorenham

Copy link
Copy Markdown
Collaborator

Summary

Fixes #3578

Merge conflicts with #3578 are unavoidable, but I tried to avoid them from getting to big (didn't check though).
I don't have a particular preference for merge order.

Test Plan

Served with integration- and unit tests.

@github-actions

Copy link
Copy Markdown

According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅

@meta-codesync

meta-codesync Bot commented May 26, 2026

Copy link
Copy Markdown
Contributor

@yangdanny97 has imported this pull request. If you are a Meta employee, you can view this in D106426454.

@kinto0 kinto0 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review automatically exported from Phabricator review in Meta.

@meta-codesync

meta-codesync Bot commented May 29, 2026

Copy link
Copy Markdown
Contributor

@yangdanny97 merged this pull request in 34861b1.

@jorenham
jorenham deleted the gh-3578 branch May 29, 2026 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

pyrefly report should include private names listed in __all__

2 participants