Goodpractises docs reorganization/review #1212
Conversation
This is not required in latest versions of `setuptools`, and `self.test_args` is a read-only attribute in some of the versions of the 18.X series. Fix pytest-dev#1134
Nowadays virtualenv use is widespread so we don't need to devote a how-to section in pytest's docs
|
|
||
| Add this to ``setup.py`` file:: | ||
| .. code-block:: python | ||
|
|
There was a problem hiding this comment.
We should additionally get rid of distutils refs while we are at it
|
|
||
| scripts/activate # on Windows | ||
| * collection starts from paths specified in :confval:`testpaths` if configured, | ||
| otherwise from initial command line arguments which may be directories, |
There was a problem hiding this comment.
that's ambiguous. https://pytest.org/latest/customize.html#confval-testpaths is more precise in saying that if you are specifying command line args "testpaths" is not considered.
|
apart from the two minor comments i am fine with merging this. |
|
well done do we have the issue references of all those that are solved by this one, i think its a actual bunch |
|
@hpk42 thanks for the comments, I will apply them and then we can merge. @RonnyPfannschmidt they are all referenced in the commit messages so the issues should be closed when we merge this, but I'll make sure they are. |
|
Applied requested changes. @hpk42 please review the new wording... feel free to suggest something better as well. 😄 |
|
Well done @hpk42 I think it s ready for merge |
Goodpractises docs reorganization/review
|
👍 |
Fixed #1134 and took opportunity to review and reorganize
goodpractisesa little... deprecated:directive;genscriptintegration, since the latter is deprecated anyway;toxandvirtualenvsessions: Nowadays virtualenv's usage is pretty standard so we don't need to devote a how-to section in pytest's docs