-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Goodpractises docs reorganization/review #1212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
c6f90c2
Remove finalize_options override from goodpractices
nicoddemus b1f6dc2
Moved "conventions for Python test discovery to the top"
nicoddemus 4f17d56
Move deprecated genscript method to the bottom of the document
nicoddemus 0704fca
Removed setuptools/genscript session
nicoddemus d851a8f
Fixed some formatting
nicoddemus 69ef0ab
Merged virtual env into the Tox section
nicoddemus 095abfd
Fix formatting errors
nicoddemus 5040dde
Fix genscript deprecation version and document reasons for such
nicoddemus d9b78f2
Remove reference to distutils
nicoddemus 464e16d
Removed incorrect note about genscript requiring wheels
nicoddemus 9475cd3
Replace "--assertmode=off" by "--assert=plain"
nicoddemus bb4771c
Remove promise about documenting how to create a zipped pytest
nicoddemus 8c74bb0
Improve description on how pytest starts test collection in goodpract…
nicoddemus File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should additionally get rid of distutils refs while we are at it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done!