-
Notifications
You must be signed in to change notification settings - Fork 259
Add support of inline tables in include on pyproject.toml. #6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
6a49b8d to
9f9c96d
Compare
cb519f5 to
c6401a2
Compare
|
@stephsamson this should also resolve python-poetry/poetry#2087 correct? |
|
As per our discussion in discord, For instance, in my project i would like to embed the My application has the structure What I would like to do is copy, at build time, import importlib.resources as resources
import toml
import src # root application package (renames are planned)
package_meta = toml.loads(resources.read_text(src, "pyproject.toml"))
src.__version__ = package_meta['tool']['poetry']['version'] |
0ebf500 to
1df2dc7
Compare
Yes! |
e220f8b to
54ab491
Compare
e662057 to
1d0c316
Compare
abn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor changes
…ckage` directive. Unify common logic between WheelBuilder and Builder. Move SDistBuilder logic from Builder to SDistBuilder. Resolves: #8
abn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor improvements suggested in #31
fix/includes: minor improvements
abn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unused pdb import needs to be removed
We want to ship various files in the source distribution, but they are not packages. Including them in the packages option of poetry seemed to work for building the sdist and wheels, but it broke poetry install. The correct way to do this was implemented in Poetry with python-poetry/poetry-core#6. This fix is in an as-yet unreleased version, unfortunately.
Resolves: #8
This PR supports inline tables in the include directive. This is similarly functional to the
packagedirective.