Skip to content

Conversation

@kasteph
Copy link
Member

@kasteph kasteph commented Apr 5, 2020

Resolves: #2353
Relates to: python-poetry/poetry-core#6
Resolves: #3823

This PR is an accompaniment to the pull request on core which add inline tables to include in pyproject.toml.

@kasteph kasteph added the area/docs Documentation issues/improvements label Apr 5, 2020
@abn abn added the status/waiting-on-core Requires changes to poetry-core first label Apr 5, 2020
@abn
Copy link
Member

abn commented Apr 5, 2020

This cannot be merged until next core release with python-poetry/core#8 is used in poetry.

@abn
Copy link
Member

abn commented May 10, 2020

@stephsamson is the documentation on this still up-to-date? Also, we should consider rebasing this onto develop as master (1.0.x) releases will not have this feature.

@sbraz
Copy link

sbraz commented Oct 10, 2020

Hi, can this doc be fixed and merged? It looks like the key was changed from include to path, making this the correct syntax that works with poetry-core 1.0.0:

include = [
    { path = "tests", format = "sdist" },
    { path = "for_wheel.txt", format = "wheel" }
]

@kasteph kasteph requested a review from sdispater October 27, 2020 19:34
@kasteph kasteph force-pushed the docs/include-inline-table branch from 70dd3c5 to 1a55dec Compare October 27, 2020 19:34
@kasteph kasteph requested a review from a team October 28, 2020 10:46
@kasteph kasteph unassigned abn Oct 28, 2020
@kasteph kasteph requested a review from abn November 24, 2020 12:52
@sinoroc
Copy link

sinoroc commented Nov 24, 2020

Related: #2015 #3380

@sinoroc
Copy link

sinoroc commented Nov 28, 2020

What is the difference between packages and include?

See for example: #3380 (comment)

@abn abn merged commit 0eaf943 into master Mar 23, 2021
@abn abn deleted the docs/include-inline-table branch March 23, 2021 14:53
@github-actions
Copy link

github-actions bot commented Mar 1, 2024

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area/docs Documentation issues/improvements status/waiting-on-core Requires changes to poetry-core first

Projects

None yet

Development

Successfully merging this pull request may close these issues.

include = [ { path = "...", format = "..." } ] feature not documented Including tests dir in sdist breaks install

6 participants