Skip to content

GitHub Actions take 2 #1414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 31 commits into from
Nov 29, 2020
Merged

Conversation

ocefpaf
Copy link
Member

@ocefpaf ocefpaf commented Nov 9, 2020

  • make this work ;-p
  • add tests latest branca
  • add tarball tests
  • add selenium tests
  • notebook code and standards tests
  • build docs/linkcheck

Linux and notebook tests need mamba-org/mamba#579

@Conengmo
Copy link
Member

Conengmo commented Nov 9, 2020

Appreciate the effort @ocefpaf! I read about the Travis changes, it's unfortunate.

@ocefpaf ocefpaf force-pushed the GH_actions branch 3 times, most recently from 9f7ea71 to 7e3df58 Compare November 9, 2020 21:38
@ocefpaf
Copy link
Member Author

ocefpaf commented Nov 9, 2020

I read about the Travis changes, it's unfortunate.

Yeah. Travis-CI was the best CI service out there and always very generous to OSS. But this has been a slow death since last year when they got bought by Idera :-(

@ocefpaf ocefpaf force-pushed the GH_actions branch 3 times, most recently from 9d90f71 to 1d7b448 Compare November 9, 2020 23:20
@ocefpaf ocefpaf force-pushed the GH_actions branch 2 times, most recently from f776dca to 44de061 Compare November 10, 2020 11:43
@ocefpaf ocefpaf force-pushed the GH_actions branch 12 times, most recently from 54f06a3 to 5f39b73 Compare November 11, 2020 13:28
@ocefpaf
Copy link
Member Author

ocefpaf commented Nov 16, 2020

I think it's important for users that they can see the example notebooks without having to run anything. We have that feature now, and I don't think a cleaner repo is worth killing it.

Fair enough. The last commit re-add the outputs. I cleanup a bit by removing unnecessary debug code that saved the HTML and the mplleaflet notebook that was broken b/c mplleaflet no longer works with modern matplotlin.

@Conengmo
Copy link
Member

Thanks, I’m a week off this week though and AFK, so I’ll take a look on Sunday if that’s okay

@ocefpaf
Copy link
Member Author

ocefpaf commented Nov 18, 2020

Thanks, I’m a week off this week though and AFK, so I’ll take a look on Sunday if that’s okay

There is no hurry. Thanks!

@ocefpaf
Copy link
Member Author

ocefpaf commented Nov 19, 2020

@Conengmo I'll leave that failure here for a while b/c @wolfv is looking into the micromamba there. I'll revert it back to macOS, where this passes, when we are ready to merge.

@wolfv
Copy link

wolfv commented Nov 19, 2020

hey, I cloned your repo. so hopefully .. I can recreate this issue :) I hope I'll get to fixing this in the course of next week... or maybe ... tomorrow. But can't promise

@ocefpaf ocefpaf force-pushed the GH_actions branch 2 times, most recently from fd28e0c to 3846ed1 Compare November 28, 2020 22:37
@ocefpaf ocefpaf force-pushed the GH_actions branch 6 times, most recently from d271830 to c47d1af Compare November 29, 2020 00:14
@ocefpaf
Copy link
Member Author

ocefpaf commented Nov 29, 2020

@Conengmo this is all conda now, no experimental micromamba (at least until it matures and works on Linux). I removed AppVeyor, all Windows tests run on GH Actions too.

The only missing piece are the docs. I'll work on them in another PR b/c this one is already overwhelmingly big.

Do you mind taking a last look and merging it?

@Conengmo Conengmo merged commit ae12f97 into python-visualization:master Nov 29, 2020
@Conengmo
Copy link
Member

Great that you got all these test working on Actions!

@ocefpaf ocefpaf deleted the GH_actions branch November 29, 2020 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants