Skip to content

Remove blurb split; after 3.2 NEWS is generated from next/*, not vice versa #440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Aug 7, 2022
Merged

Remove blurb split; after 3.2 NEWS is generated from next/*, not vice versa #440

merged 6 commits into from
Aug 7, 2022

Conversation

arhadthedev
Copy link
Member

@arhadthedev arhadthedev commented Apr 12, 2022

The blurb split command fixes known historical issues of Misc/NEWS and splits it into Misc/NEWS.d/*.rst.

However, it lost any use in Python 3.2 when it was replaced with direct committing of Misc/NEWS.d/*.*.*.rst.

So this PR:

  • removes this command
  • cleans up leftover functions&imports
  • replaces verbal mentions of Misc/NEWS with mentions of Misc/NEWS.d and Misc/NEWS.d/next.
Edit: initially I was way too ambitious and desired to remove blurb merge as well

The blurb tool has two commands that manipulate Misc/NEWS file. However, they lost any use in Python 3.2 when it was replaced with direct committing of Misc/NEWS.d/*.*.*.rst. These commands are:

  • blurb merge (glues new Misc/NEWS.d/*.rst into old Misc/NEWS)
  • blurb split (fixes known historical issues of Misc/NEWS and splits it back into Misc/NEWS.d/*.rst)
  • it was performed last time in python/cpython@260a788 and was never used again

This PR removes these commands, cleans up leftover functions&imports, and replaces verbal mentions of Misc/NEWS with mentions of Misc/NEWS.d or Misc/NEWS.d/next.

@hugovk
Copy link
Member

hugovk commented Apr 13, 2022

The blurb tool has two commands that manipulate Misc/NEWS file. However, they lost any use in Python 3.2 when it was replaced with direct committing of Misc/NEWS.d/*.*.*.rst.

Does that mean we don't need python/cpython#30419 and #147?

If so, there's a bunch of blurb NEWS stuff that could be removed from https://github.com/python/cpython/blob/main/Doc/Makefile.

@hugovk hugovk requested a review from larryhastings April 13, 2022 05:01
@arhadthedev
Copy link
Member Author

@hugovk Thank you for noticing! I looked further and found that blurb merge is used to generate NEWS.txt for Windows distribution. So I reverted this command back.

@ambv ambv closed this Apr 15, 2022
@ambv ambv reopened this Apr 15, 2022
@arhadthedev arhadthedev changed the title Remove blurb processing of the long gone Misc/NEWS file Remove blurb split because Misc/NEWS fstopped to be the sourcelong ago Apr 18, 2022
@arhadthedev arhadthedev changed the title Remove blurb split because Misc/NEWS fstopped to be the sourcelong ago Remove blurb split because Misc/NEWS stopped to be the primary source long ago Apr 18, 2022
@arhadthedev arhadthedev changed the title Remove blurb split because Misc/NEWS stopped to be the primary source long ago Remove blurb split; after 3.2 NEWS is generated from next/*, not vice versa Apr 18, 2022
@arhadthedev
Copy link
Member Author

@larryhastings ping

@arhadthedev
Copy link
Member Author

@larryhastings Can this PR be merged, please?

@arhadthedev
Copy link
Member Author

Someone please?

@ezio-melotti ezio-melotti requested a review from Mariatta July 15, 2022 01:15
@arhadthedev
Copy link
Member Author

Erm... ping?

@gpshead
Copy link
Member

gpshead commented Aug 7, 2022

If for some reason we ever needed this again, that is what we have a version control system for. :)

@gpshead gpshead merged commit 02cf279 into python:master Aug 7, 2022
@arhadthedev arhadthedev deleted the old-news branch August 7, 2022 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants