Skip to content

Upload NEWS file as artifact #30419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Nov 23, 2022
Merged

Conversation

hugovk
Copy link
Member

@hugovk hugovk commented Jan 5, 2022

Fixes python/core-workflow#147.

Since that issue was opened, we've moved testing from Travis CI to GitHub Actions.

And more recently the blurb tool is now being as part of make build called as part of make ... doctest in the "Check documentation" step (#30009).

So let's also upload the generated NEWS file as an artifact so it can be inspected after the build.

For example, it's available to download here:

Copy link
Contributor

@erlend-aasland erlend-aasland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat!

@hugovk
Copy link
Member Author

hugovk commented Feb 28, 2022

Conflict resolved!

Would be nice to get this merged, it'd make reviewing docs PRs much easier: can download the generated files rather than checking out the branch locally and building them manually.

@hugovk
Copy link
Member Author

hugovk commented Jun 4, 2022

Conflict resolved!

@merwok merwok requested a review from ezio-melotti as a code owner November 22, 2022 18:03
@smontanaro
Copy link
Contributor

(I'm working my way through some PRs which have been approved and are labeled "awaiting merge", hence my seemingly bolt from the blue comment. Why? Read here.)

Can this be merged or are you still waiting for @Mariatta and @ezio-melotti to review?

Copy link
Member

@ezio-melotti ezio-melotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we know how much storage is the python org using?
I don't expect the NEWS file to be particularly large, but if it gets generated for each PR it will add up and we might eventually reach the limit. We can also tweak the number of day the artifact is stored before being automatically deleted.

Other than that, the PR LGTM.

@hugovk
Copy link
Member Author

hugovk commented Nov 23, 2022

The current usage will be visible under https://github.com/organizations/python/settings/billing for org admins.

@hugovk
Copy link
Member Author

hugovk commented Nov 23, 2022

Also the NEWS file is only 2% the size of the docs artifact we've been uploading for a long time and apparently that's not been a problem.

image

Copy link
Member

@ezio-melotti ezio-melotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In that case I guess it's not a problem. FWIW the artifact retention period is currently set at 90 days. We can lower it if space becomes a problem.

@ezio-melotti ezio-melotti merged commit 57dfb1c into python:main Nov 23, 2022
@hugovk hugovk deleted the gha-blurb-upload-news branch November 24, 2022 03:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Run blurb as part of Travis
9 participants