-
-
Notifications
You must be signed in to change notification settings - Fork 31.9k
Upload NEWS file as artifact #30419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upload NEWS file as artifact #30419
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Neat!
Conflict resolved! Would be nice to get this merged, it'd make reviewing docs PRs much easier: can download the generated files rather than checking out the branch locally and building them manually. |
Conflict resolved! |
(I'm working my way through some PRs which have been approved and are labeled "awaiting merge", hence my seemingly bolt from the blue comment. Why? Read here.) Can this be merged or are you still waiting for @Mariatta and @ezio-melotti to review? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we know how much storage is the python
org using?
I don't expect the NEWS
file to be particularly large, but if it gets generated for each PR it will add up and we might eventually reach the limit. We can also tweak the number of day the artifact is stored before being automatically deleted.
Other than that, the PR LGTM.
The current usage will be visible under https://github.com/organizations/python/settings/billing for org admins. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In that case I guess it's not a problem. FWIW the artifact retention period is currently set at 90 days. We can lower it if space becomes a problem.
Fixes python/core-workflow#147.
Since that issue was opened, we've moved testing from Travis CI to GitHub Actions.
And more recently the blurb tool is now being as part of
make build
called as part ofmake ... doctest
in the "Check documentation" step (#30009).So let's also upload the generated
NEWS
file as an artifact so it can be inspected after the build.For example, it's available to download here: