Improvements to test.support.interpreters.Interpreter #132775

ericsnowcurrently · 2025-04-21T16:08:49Z

Interpreter.call() should be able to support arbitrary callables, full args, and return values.

Linked PRs

The text was updated successfully, but these errors were encountered:

…h-132974) This change consists of adding tests and moving code around, with some renaming thrown in.

…eUTF8() (gh-132979) They are derived from the existing `PyModule_GetFilenameObject(). They are used by a later change related to pickle and handling __main__.

We replace it with _Py_GetMainModule(), and add _Py_CheckMainModule(), but both in the internal-only C-API. We also add _PyImport_GetModulesRef(), which is the equivalent of _PyImport_GetModules(), but which increfs before the lock is released. This is used by a later change related to pickle and handling __main__.

This is the base for several other XIData wrappers, like pickle and marshal. It is essentially a refactor of the existing bytes XIData code.

Note that the bulk of this change is tests.

The function indicates whether or not the function has a return statement. This is used by a later change related treating some functions like scripts.

markshannon · 2025-04-29T14:31:20Z

Could you elaborate what the "minor issues" are?
Either as a task list or sub issues?

It isn't clear to me why, for example, #132981 is needed, or if it is the right solution to whatever the problem is.

This helper is useful in a variety of ways, including in demonstrating how the different counts relate to one another. It will be used in a later change to help identify if a function is "stateless", meaning it doesn't have any free vars or globals. Note that a majority of this change is tests.

There's some extra complexity due to making sure we we get things right when handling functions and classes defined in the __main__ module. This is also reflected in the tests, including the addition of extra functions in test.support.import_helper.

This reverts commit 94b4fcd.

The change broke the s390 builds, so I'm reverting it while I investigate. This reverts commit 94b4fcd.

This reverts commit 811edcf (pythongh-133128).

It now supports a "full" fallback to _PyFunction_GetXIData() and then `_PyPickle_GetXIData()`. There's also room for other fallback modes if that later makes sense.

…-133482) It now supports a "full" fallback to _PyFunction_GetXIData() and then `_PyPickle_GetXIData()`. There's also room for other fallback modes if that later makes sense. (cherry picked from commit 88f8102) Co-authored-by: Eric Snow <[email protected]>

It now supports a "full" fallback to _PyFunction_GetXIData() and then `_PyPickle_GetXIData()`. There's also room for other fallback modes if that later makes sense. (cherry picked from commit 88f8102, AKA gh-133482) Co-authored-by: Eric Snow <[email protected]>

…ess() (gh-134439)

…Stateless() (pythongh-134439) (cherry picked from commit a66bae8) Co-authored-by: Eric Snow <[email protected]>

…yStateless() (gh-134465) (cherry picked from commit a66bae8, AKA gh-134439) Co-authored-by: Eric Snow <[email protected]>

This change includes some semi-related refactoring of queues and channels.

…4440) This change includes some semi-related refactoring of queues and channels. (cherry picked from commit d0eedfa) Co-authored-by: Eric Snow <[email protected]>

This change includes some semi-related refactoring of queues and channels. (cherry picked from commit d0eedfa, gh-134440) Co-authored-by: Eric Snow <[email protected]>

(cherry picked from commit 09e72cf) Co-authored-by: Eric Snow <[email protected]>

(cherry picked from commit 09e72cf, AKA gh-134511) Co-authored-by: Eric Snow <[email protected]>

This is mostly a refactor to clean things up a bit, most notably the "XI namespace" code. Making the session opaque requires adding the following internal-only functions: * _PyXI_NewSession() * _PyXI_FreeSession() * _PyXI_GetMainNamespace()

This is mostly a refactor to clean things up a bit, most notably the "XI namespace" code. Making the session opaque requires adding the following internal-only functions: * _PyXI_NewSession() * _PyXI_FreeSession() * _PyXI_GetMainNamespace() (cherry picked from commit 4a4ac3ab4d2a34af99af9e948be9cd1257ed4186) Co-authored-by: Eric Snow <[email protected]>

This is mostly a refactor to clean things up a bit, most notably the "XI namespace" code. Making the session opaque requires adding the following internal-only functions: * _PyXI_NewSession() * _PyXI_FreeSession() * _PyXI_GetMainNamespace() (cherry picked from commit 4a4ac3a, gh-134452) Co-authored-by: Eric Snow <[email protected]>

(cherry picked from commit ac06b53) Co-authored-by: Eric Snow <[email protected]>

(cherry picked from commit ac06b53, AKA gh-134530) Co-authored-by: Eric Snow <[email protected]>

ericsnowcurrently added the type-bug An unexpected behavior, bug, or error label Apr 21, 2025

ericsnowcurrently self-assigned this Apr 21, 2025

ericsnowcurrently added this to Subinterpreters Apr 21, 2025

github-project-automation bot moved this to Todo in Subinterpreters Apr 21, 2025

ericsnowcurrently added stdlib Python modules in the Lib dir topic-subinterpreters 3.14 bugs and security fixes labels Apr 21, 2025

ericsnowcurrently added a commit that referenced this issue Apr 28, 2025

gh-132775: Cleanup Related to crossinterp.c Before Further Changes (g…

6f04325

…h-132974) This change consists of adding tests and moving code around, with some renaming thrown in.

bedevere-app bot mentioned this issue Apr 28, 2025

gh-132775: Add _PyBytes_GetXIData() #133101

Merged

ericsnowcurrently added a commit that referenced this issue Apr 28, 2025

gh-132775: Add _PyBytes_GetXIData() (gh-133101)

606003f

This is the base for several other XIData wrappers, like pickle and marshal. It is essentially a refactor of the existing bytes XIData code.

This was referenced Apr 28, 2025

gh-132775: Add _PyPickle_GetXIData() #133107

Merged

gh-132775: Add _PyMarshal_GetXIData() #133108

Merged

ericsnowcurrently added a commit that referenced this issue Apr 28, 2025

gh-132775: Add _PyMarshal_GetXIData() (gh-133108)

bdd23c0

Note that the bulk of this change is tests.

ericsnowcurrently added a commit that referenced this issue Apr 29, 2025

gh-132775: Add _PyCode_ReturnsOnlyNone() (gh-132981)

96a7fb9

The function indicates whether or not the function has a return statement. This is used by a later change related treating some functions like scripts.

bedevere-app bot mentioned this issue Apr 29, 2025

gh-132775: Add _PyCode_GetVarCounts() #133128

Merged

bedevere-app bot mentioned this issue Apr 30, 2025

gh-132775: Add _PyCode_VerifyStateless() #133221

Merged

ericsnowcurrently added a commit to ericsnowcurrently/cpython that referenced this issue May 1, 2025

Revert "pythongh-132775: Add _PyCode_GetVarCounts() (pythongh-133128)"

1740ecb

This reverts commit 94b4fcd.

ericsnowcurrently added a commit that referenced this issue May 1, 2025

Revert "gh-132775: Add _PyCode_GetVarCounts() (gh-133128)" (gh-133232)

811edcf

The change broke the s390 builds, so I'm reverting it while I investigate. This reverts commit 94b4fcd.

ericsnowcurrently added a commit to ericsnowcurrently/cpython that referenced this issue May 1, 2025

pythongh-132775: Unrevert "Add _PyCode_GetVarCounts()"

d9c3672

This reverts commit 811edcf (pythongh-133128).

bedevere-app bot mentioned this issue May 1, 2025

gh-132775: Unrevert "Add _PyCode_GetVarCounts()" #133265

Merged

bedevere-app bot mentioned this issue May 21, 2025

[3.14] gh-132775: Support Fallbacks in _PyObject_GetXIData() (gh-133482) #134418

Merged

ericsnowcurrently added a commit that referenced this issue May 21, 2025

gh-132775: Use _PyFunction_VerifyStateless() and _PyCode_VerifyStatel…

a66bae8

…ess() (gh-134439)

bedevere-app bot mentioned this issue May 21, 2025

[3.14] gh-132775: Use _PyFunction_VerifyStateless() and _PyCode_VerifyStateless() (gh-134439) #134465

Merged

ericsnowcurrently added a commit that referenced this issue May 21, 2025

[3.14] gh-132775: Use _PyFunction_VerifyStateless() and _PyCode_Verif…

93ab55b

…yStateless() (gh-134465) (cherry picked from commit a66bae8, AKA gh-134439) Co-authored-by: Eric Snow <[email protected]>

ericsnowcurrently added a commit that referenced this issue May 22, 2025

gh-132775: Use _PyObject_GetXIData (With Fallback) (gh-134440)

d0eedfa

This change includes some semi-related refactoring of queues and channels.

bedevere-app bot mentioned this issue May 22, 2025

[3.14] gh-132775: Use _PyObject_GetXIData (With Fallback) (gh-134440) #134507

Merged

bedevere-app bot mentioned this issue May 22, 2025

gh-132775: Use _PyCode GetScriptXIData() #134511

Merged

ericsnowcurrently added a commit that referenced this issue May 22, 2025

gh-132775: Use _PyCode GetScriptXIData() (gh-134511)

09e72cf

miss-islington pushed a commit to miss-islington/cpython that referenced this issue May 22, 2025

pythongh-132775: Use _PyCode GetScriptXIData() (pythongh-134511)

e576b24

(cherry picked from commit 09e72cf) Co-authored-by: Eric Snow <[email protected]>

bedevere-app bot mentioned this issue May 22, 2025

[3.14] gh-132775: Use _PyCode GetScriptXIData() (gh-134511) #134515

Merged

ericsnowcurrently added a commit that referenced this issue May 22, 2025

[3.14] gh-132775: Use _PyCode GetScriptXIData() (gh-134515)

bbf8048

(cherry picked from commit 09e72cf, AKA gh-134511) Co-authored-by: Eric Snow <[email protected]>

This was referenced May 22, 2025

[3.14] gh-132775: Make _PyXI_session Opaque (gh-134452) #134522

Merged

gh-132775: Fix Recently Introduced Warnings #134530

Merged

ericsnowcurrently added a commit that referenced this issue May 22, 2025

gh-132775: Fix Recently Introduced Warnings (gh-134530)

ac06b53

miss-islington pushed a commit to miss-islington/cpython that referenced this issue May 22, 2025

pythongh-132775: Fix Recently Introduced Warnings (pythongh-134530)

06774c3

(cherry picked from commit ac06b53) Co-authored-by: Eric Snow <[email protected]>

bedevere-app bot mentioned this issue May 22, 2025

[3.14] gh-132775: Fix Recently Introduced Warnings (gh-134530) #134532

Merged

ericsnowcurrently added a commit that referenced this issue May 22, 2025

[3.14] gh-132775: Fix Recently Introduced Warnings (gh-134532)

7480e50

(cherry picked from commit ac06b53, AKA gh-134530) Co-authored-by: Eric Snow <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Improvements to test.support.interpreters.Interpreter #132775

Improvements to test.support.interpreters.Interpreter #132775

ericsnowcurrently commented Apr 21, 2025 •

edited by bedevere-app bot

Loading

markshannon commented Apr 29, 2025

Uh oh!

Uh oh!

Improvements to test.support.interpreters.Interpreter #132775

Improvements to test.support.interpreters.Interpreter #132775

Comments

ericsnowcurrently commented Apr 21, 2025 • edited by bedevere-app bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Linked PRs

markshannon commented Apr 29, 2025

Uh oh!

ericsnowcurrently commented Apr 21, 2025 •

edited by bedevere-app bot

Loading