Skip to content

Add a version added note for PY_VECTORCALL_ARGUMENTS_OFFSET #110963

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 23, 2023

Conversation

tonybaloney
Copy link
Contributor

@tonybaloney tonybaloney commented Oct 17, 2023

Trivial change.

METH_FASTCALL was added in 3.7, vector call came in 3.8.

The macro PY_VECTORCALL_ARGUMENTS_OFFSET doesn't have the version added (it was 3.8)


📚 Documentation preview 📚: https://cpython-previews--110963.org.readthedocs.build/

@bedevere-app bedevere-app bot added awaiting review docs Documentation in the Doc dir skip news labels Oct 17, 2023
@hugovk hugovk changed the title Add a version added note for PY_VECTORCALL_ARGUMENT_OFFSET Add a version added note for PY_VECTORCALL_ARGUMENTS_OFFSET Oct 23, 2023
@hugovk hugovk added needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Oct 23, 2023
Copy link
Member

@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed added in 3.8 in PR #13185. Thank you!

@hugovk hugovk merged commit be551a7 into python:main Oct 23, 2023
@miss-islington-app
Copy link

Thanks @tonybaloney for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 23, 2023
@bedevere-app
Copy link

bedevere-app bot commented Oct 23, 2023

GH-111219 is a backport of this pull request to the 3.12 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 23, 2023
@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Oct 23, 2023
@bedevere-app
Copy link

bedevere-app bot commented Oct 23, 2023

GH-111220 is a backport of this pull request to the 3.11 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.11 only security fixes label Oct 23, 2023
hugovk pushed a commit that referenced this pull request Oct 23, 2023
hugovk pushed a commit that referenced this pull request Oct 23, 2023
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip issue skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants