-
-
Notifications
You must be signed in to change notification settings - Fork 31.9k
bpo-36974: PEP 590 #13185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bpo-36974: PEP 590 #13185
Conversation
025d6d4
to
746c2af
Compare
4ea6af5
to
aa440cc
Compare
d9a1bd8
to
ac4da56
Compare
…ctions Test functions are renamed to reflect the C API they're testing.
I went through the code, and made a few small changes. Do they look OK to you? |
I don't agree with 7536e69 for two reasons:
|
Lib/test/test_capi.py
Outdated
from types import MethodType | ||
from functools import partial | ||
|
||
def vectorcall(func, args, kwargs=None): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you want to set a default for kwargs
, it should be kwargs={}
.
Lib/test/test_capi.py
Outdated
def test_vectorcall(self): | ||
# Test a bunch of different ways to call objects: | ||
# 1. normal call | ||
# 2. vectorcall |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be good to fix this comment, as you're adding a new way of testing the call.
No further comments. |
I'm not entirely convinced on the recursivecall, but it's probably OK to leave out.
I'm out for a couple of hours. Could you push a revert and your suggested changes to get the CI going?
…On May 29, 2019 5:17:12 PM GMT+02:00, Jeroen Demeyer ***@***.***> wrote:
No further comments.
--
You are receiving this because you were assigned.
Reply to this email directly or view it on GitHub:
#13185 (comment)
--
Sent from my Android device with K-9 Mail. Please excuse my brevity.
|
|
|
|
Oh! |
|
|
All buildbots are green now. Thank you, @jdemeyer and @markshannon, for putting this together! Docs should come in early beta. |
Petr, thank you for reviewing and merging and in particular fixing the buildbot failure. About follow-ups:
The others are less important and can wait. |
Co-authored-by: Jeroen Demeyer <[email protected]> Co-authored-by: Mark Shannon <[email protected]>
Implementation of PEP 590 by Mark Shannon and Jeroen Demeyer.
CC @encukou @markshannon
https://bugs.python.org/issue36974