Skip to content

bpo-36974: handle inheritance of vectorcall protocol #13498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 30, 2019
Merged

bpo-36974: handle inheritance of vectorcall protocol #13498

merged 1 commit into from
May 30, 2019

Conversation

jdemeyer
Copy link
Contributor

@jdemeyer jdemeyer commented May 22, 2019 •
edited by bedevere-bot
Loading

@jdemeyer jdemeyer changed the title [WIP] bpo-36974: handle inheritance of vectorcall protocol bpo-36974: handle inheritance of vectorcall protocol May 29, 2019
@jdemeyer jdemeyer marked this pull request as ready for review May 29, 2019 13:26
@jdemeyer jdemeyer requested review from 1st1 and asvetlov as code owners May 29, 2019 13:26
asvetlov
asvetlov approved these changes May 29, 2019
View reviewed changes
Copy link
Contributor

@asvetlov asvetlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good for asyncio part

encukou
encukou approved these changes May 29, 2019
View reviewed changes
Copy link
Member

@encukou encukou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall!
(Not merging right now as I won't be able to watch buildbots)

@jdemeyer jdemeyer mentioned this pull request May 30, 2019
Merged
@encukou encukou merged commit 735e8af into python:master May 30, 2019
DinoV pushed a commit to DinoV/cpython that referenced this pull request Jan 14, 2020
@jdemeyer @DinoV
bpo-36974: inherit the vectorcall protocol (pythonGH-13498)
85965d2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@encukou encukou encukou approved these changes

@asvetlov asvetlov asvetlov approved these changes

@1st1 1st1 Awaiting requested review from 1st1

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jdemeyer @encukou @asvetlov @the-knights-who-say-ni @bedevere-bot