Use _PyLong_GetOne() and _PyLong_GetZero() in long_invmod() #125044
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These functions cannot fail.
kumaraditya303
approved these changes
Oct 7, 2024
|
Merged, thanks for reviews! |
This was referenced Oct 14, 2024
eendebakpt
reviewed
Oct 14, 2024
| return NULL; | ||
| } | ||
| Py_INCREF(a); | ||
| PyLongObject *b = (PyLongObject *)Py_NewRef(_PyLong_GetOne()); |
There was a problem hiding this comment.
@vstinner Out of curiosity: why did you add the Py_NewRef when _PyLong_GetOne is documented to return an immortal singleton?
(or can modern compilers optimize this away?)
There was a problem hiding this comment.
The Py_NewRef() is useless. I added it because the code wants a strong refererence and I didn't pay attention that these two constants are immortal.
(or can modern compilers optimize this away?)
No, Py_NewRef() is not optimized.
See also my PR gh-124076 attempt.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These functions cannot fail.