-
-
Notifications
You must be signed in to change notification settings - Fork 31.9k
Use _PyLong_GetOne() in long_pow() #125474
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
Can you update the branch? |
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
Please add title label, like this
|
This is a trivial change which might skip issue 😊 |
And, this has been rejected by the core-dev, I don't think this modification is meaningful. |
But similar change has been merged as I mentioned, and I think the last PR has been rejected because it changed so many places which makes code ugly, different from this PR. I think it is meaningful to keep the code style the same in the same file. |
My suggestion is to open an issue and listen to other people's opinions. |
Since a core-dev has approved similar change, and I'm just doing something to finish his incomplete change, it should be just fine. I found this place when studying this file and want to do something to make the code style the same 🥲 |
You might be talking about this In fact, changing the code style alone isn't allowed. You should also modify other functions to pass. |
Okay, sorry to trouble you 🙏. |
@rruuaanng, please try and keep a polite tone. @hikariyo: Thanks for the PR, but as has been noted, pretty much all code changes, including refactorings1, need issues. Please see the devguide for more info :) Footnotes
|
I'm sorry, I'm not hostile. Maybe I should bring a smile🙂 Footnotes
|
It often helps to use more friendly words. Instead of "I don't think this modification is meaningful", try instead to ask what the author intends to achieve with the change. @rruuaanng, see also https://opensource.guide/how-to-contribute/#how-to-submit-a-contribution. |
Just another place like what #125044 did. It makes code clearer.