Skip to content

gh-125940: Android: support 16 KB pages #125941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 24, 2024
Merged

gh-125940: Android: support 16 KB pages #125941

merged 1 commit into from
Oct 24, 2024

Conversation

mhsmith
Copy link
Member

@mhsmith mhsmith commented Oct 24, 2024 •
edited
Loading

For details, see chaquo/chaquopy#1171.

This should be backported to 3.13, as it ensures that builds produced today will continue to work on devices released a couple of years from now.

@mhsmith mhsmith added the needs backport to 3.13 bugs and security fixes label Oct 24, 2024
@bedevere-app bedevere-app bot mentioned this pull request Oct 24, 2024
Closed
@mhsmith
Copy link
Member Author

mhsmith commented Oct 24, 2024

!buildbot android

@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @mhsmith for commit 0059ff3 🤖

The command will test the builders whose names match following regular expression: android

The builders matched are:

  • aarch64 Android PR
  • AMD64 Android PR

@mhsmith
Copy link
Member Author

mhsmith commented Oct 24, 2024 •
edited
Loading

The failure on aarch64 appears to be intermittent and unrelated – see #118201 (comment).

!buildbot aarch64 Android

@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @mhsmith for commit 0059ff3 🤖

The command will test the builders whose names match following regular expression: aarch64 Android

The builders matched are:

  • aarch64 Android PR

@mhsmith mhsmith requested a review from freakboy3742 October 24, 2024 22:27
@mhsmith mhsmith mentioned this pull request Oct 24, 2024
Merged
freakboy3742
freakboy3742 approved these changes Oct 24, 2024
View reviewed changes
Copy link
Contributor

@freakboy3742 freakboy3742 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Makes sense to me.

@freakboy3742 freakboy3742 merged commit e68d4b0 into python:main Oct 24, 2024
41 checks passed
@miss-islington-app
Copy link

Thanks @mhsmith for the PR, and @freakboy3742 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 24, 2024
@mhsmith @miss-islington
pythongh-125940: Android: support 16 KB pages (pythonGH-125941)
6c4c045 
Modify Android build tooling to use 16kB pages.
(cherry picked from commit e68d4b0)

Co-authored-by: Malcolm Smith <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Oct 24, 2024

GH-125948 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Oct 24, 2024
freakboy3742 pushed a commit that referenced this pull request Oct 25, 2024
@miss-islington @mhsmith
[3.13] gh-125940: Android: support 16 KB pages (GH-125941) (#125948)
904634b 
gh-125940: Android: support 16 KB pages (GH-125941)

Modify Android build tooling to use 16kB pages.
(cherry picked from commit e68d4b0)

Co-authored-by: Malcolm Smith <[email protected]>
@mhsmith mhsmith mentioned this pull request Oct 28, 2024
Closed
ebonnal pushed a commit to ebonnal/cpython that referenced this pull request Jan 12, 2025
@mhsmith @ebonnal
pythongh-125940: Android: support 16 KB pages (python#125941)
b177e64 
Modify Android build tooling to use 16kB pages.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@freakboy3742 freakboy3742 freakboy3742 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Android: support 16 KB pages
3 participants
@mhsmith @bedevere-bot @freakboy3742