Skip to content

Increase minimum Android API level to 24 #125946

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 25, 2024

Conversation

mhsmith
Copy link
Member

@mhsmith mhsmith commented Oct 24, 2024

This PR is stacked on top of #125941, which should be merged first. However, this PR should not be backported to 3.13, because that has already committed to a minimum API level of 21.

API level 24 was released in 2016, and according to https://dl.google.com/android/studio/metadata/distributions.json, over 97% of active devices are on that version or newer.

Because of limitations in the pidof and logcat commands, 24 is already the minimum API level supported by the test script – older versions had to be tested manually. So this will save some work for Python 3.14.

@mhsmith
Copy link
Member Author

mhsmith commented Oct 24, 2024

!buildbot android

@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @mhsmith for commit 55cfb94 🤖

The command will test the builders whose names match following regular expression: android

The builders matched are:

  • aarch64 Android PR
  • AMD64 Android PR

@mhsmith mhsmith requested a review from freakboy3742 October 24, 2024 23:39
@freakboy3742
Copy link
Contributor

The change itself makes sense; but there's a merge conflict after #125941 landed; once that's resolved, I think this is good to land.

Copy link
Contributor

@freakboy3742 freakboy3742 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@freakboy3742 freakboy3742 merged commit 371c537 into python:main Oct 25, 2024
40 checks passed
@freakboy3742
Copy link
Contributor

freakboy3742 commented Oct 25, 2024

Not sure why this passed a buildbot check on the PR, but then failed on the main... any ideas @mhsmith ?

@mhsmith
Copy link
Member Author

mhsmith commented Oct 26, 2024

Actually it did not pass the buildbot check on the PR (click the red X against the "Remove skip" commit above).

It looks like increasing the minimum API level has caused some additional libc APIs to become available at compile time, but they always return "permission denied" at runtime. This is a pretty common situation, so I'll make another PR to fix it.

@freakboy3742
Copy link
Contributor

/me facepalms.

I missed the original test failure, then assumed that the impact of a buildbot test failure would carry over into the subsequent merge-with-main build.

ebonnal pushed a commit to ebonnal/cpython that referenced this pull request Jan 12, 2025
Minimum Android API level has been increased to 24 (Android 7.0).
freakboy3742 pushed a commit that referenced this pull request Apr 2, 2025
Backport miscellaneous Android testbed changes from #125946, but without the
Android API version bump.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants