GH-131498: Cases generator: Parse down to C statement level. #131948
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
picnixz
reviewed
Apr 1, 2025
| raise NotImplementedError() | ||
|
|
||
|
|
||
| @dataclass |
There was a problem hiding this comment.
Maybe to reduce memory footprint, use slots=True
There was a problem hiding this comment.
I don't think it is worth it to save a few kbytes.
picnixz
reviewed
Apr 1, 2025
iritkatriel
approved these changes
Apr 2, 2025
seehwan
pushed a commit
to seehwan/cpython
that referenced
this pull request
Apr 16, 2025
…ythonGH-131948) * Parse down to statement level in the cases generator * Add handling for #if macros, treating them much like normal ifs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enhances the cases generator parser to parse instructions and labels down to C statement level.
This:
#ifconditionals like normalifstatements ensuring that the free-threading and default builds have the same properties and are properly understood by the code generator.Because we are now parsing the source, rather than simply tokenizing it, the output no longer contains the comments present in the original.