Skip to content

bpo-40645: Fix reference leak in the _hashopenssl extension #25063

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 29, 2021
Merged

bpo-40645: Fix reference leak in the _hashopenssl extension #25063

merged 1 commit into from
Mar 29, 2021

Conversation

pablogsal
Copy link
Member

@pablogsal pablogsal commented Mar 29, 2021 •
edited by miss-islington
Loading

https://bugs.python.org/issue40645

Automerge-Triggered-By: GH:tiran

@pablogsal pablogsal requested a review from tiran March 29, 2021 10:55
@pablogsal pablogsal requested a review from gpshead March 29, 2021 10:55
@pablogsal pablogsal mentioned this pull request Mar 29, 2021
Merged
2 tasks
@pablogsal
Copy link
Member Author 

𓋹 ./python.exe -m test test_hashlib -R :
0:00:00 load avg: 4.32 Run tests sequentially
0:00:00 load avg: 4.32 [1/1] test_hashlib
beginning 9 repetitions
123456789
.........

== Tests result: SUCCESS ==

1 test OK.

Total duration: 13.5 sec
Tests result: SUCCESS

vstinner
vstinner approved these changes Mar 29, 2021
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I didn't check if the change fix the leak.

@miss-islington miss-islington merged commit 70cdf18 into python:master Mar 29, 2021
@pablogsal pablogsal deleted the bpo-40645 branch May 19, 2021 19:00
stratakis pushed a commit to stratakis/cpython that referenced this pull request Aug 5, 2021
@pablogsal @stratakis
bpo-40645: Fix reference leak in the _hashopenssl extension (pythonGH…
7522d3b 
…-25063)
encukou pushed a commit to encukou/cpython that referenced this pull request Sep 8, 2021
@tiran @pablogsal @encukou
bpo-40645: use C implementation of HMAC (pythonGH-24920, pythonGH-25063…
62debb2 
…, pythonGH-26079)

This backports the feature and 2 subsequent bugfixes
from: https://bugs.python.org/issue40645

Signed-off-by: Christian Heimes <[email protected]>
Co-authored-by: Erlend Egeberg Aasland <[email protected]>
Co-Authored-By: Pablo Galindo <[email protected]>
stratakis pushed a commit to stratakis/cpython that referenced this pull request Jan 18, 2022
@tiran @pablogsal @stratakis
bpo-40645: use C implementation of HMAC (pythonGH-24920, pythonGH-25063…
6b98f14 
…, pythonGH-26079)

This backports the feature and 2 subsequent bugfixes
from: https://bugs.python.org/issue40645

Signed-off-by: Christian Heimes <[email protected]>
Co-authored-by: Erlend Egeberg Aasland <[email protected]>
Co-Authored-By: Pablo Galindo <[email protected]>
stratakis pushed a commit to stratakis/cpython that referenced this pull request Jan 21, 2022
@tiran @pablogsal @stratakis
bpo-40645: use C implementation of HMAC (pythonGH-24920, pythonGH-25063…
d0903aa 
…, pythonGH-26079)

This backports the feature and 2 subsequent bugfixes
from: https://bugs.python.org/issue40645

Signed-off-by: Christian Heimes <[email protected]>
Co-authored-by: Erlend Egeberg Aasland <[email protected]>
Co-Authored-By: Pablo Galindo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner vstinner approved these changes

@tiran tiran tiran approved these changes

@gpshead gpshead Awaiting requested review from gpshead

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@pablogsal @vstinner @tiran @the-knights-who-say-ni @bedevere-bot @miss-islington