Skip to content

bpo-40645: Fix ref leaks in _hashopenssl #26079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 12, 2021
Merged

bpo-40645: Fix ref leaks in _hashopenssl #26079

merged 1 commit into from
May 12, 2021

Conversation

erlend-aasland
Copy link
Contributor

@erlend-aasland erlend-aasland commented May 12, 2021 •
edited by bedevere-bot
Loading

@erlend-aasland erlend-aasland requested a review from tiran as a code owner May 12, 2021 17:53
@erlend-aasland
Copy link
Contributor Author

cc. @encukou

@erlend-aasland
Copy link
Contributor Author

Backport to 3.10, @pablogsal ?

@erlend-aasland erlend-aasland mentioned this pull request May 12, 2021
Merged
@pablogsal
Copy link
Member

Yup, and to any version that has this problem. Can you add the labels?

@erlend-aasland erlend-aasland added the needs backport to 3.10 only security fixes label May 12, 2021
@erlend-aasland
Copy link
Contributor Author

erlend-aasland commented May 12, 2021 •
edited
Loading

Yup, and to any version that has this problem. Can you add the labels?

GH-26072 is (currently) only being backported to 3.10, so for now I'm only adding the 3.10 label. I'll check 3.9 asap and add to both PR's if necessary. BTW, #26072 needs manual backporting.

UPDATE: Seems like the code in question was added in 933dfd7. Backporting to 3.10 should be sufficient.

@pablogsal pablogsal merged commit 504ffda into python:main May 12, 2021
@miss-islington
Copy link
Contributor

Thanks @erlend-aasland for the PR, and @pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

@erlend-aasland erlend-aasland deleted the fix-hashlib-refleaks branch May 12, 2021 18:20
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 12, 2021
@miss-islington
bpo-40645: Fix ref leaks in _hashopenssl (pythonGH-26079)
983aa4c 
(cherry picked from commit 504ffda)

Co-authored-by: Erlend Egeberg Aasland <[email protected]>
@bedevere-bot
Copy link

GH-26082 is a backport of this pull request to the 3.10 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label May 12, 2021
@pablogsal
Copy link
Member

Yup, and to any version that has this problem. Can you add the labels?

GH-26072 is (currently) only being backported to 3.10, so for now I'm only adding the 3.10 label. I'll check 3.9 asap and add to both PR's if necessary. BTW, #26072 needs manual backporting.

UPDATE: Seems like the code in question was added in 933dfd7. Backporting to 3.10 should be sufficient.

Fantastic. Thanks a lot for the patch 🎉

miss-islington added a commit that referenced this pull request May 12, 2021
@miss-islington
bpo-40645: Fix ref leaks in _hashopenssl (GH-26079)
1ee58f2 
(cherry picked from commit 504ffda)

Co-authored-by: Erlend Egeberg Aasland <[email protected]>
@pablogsal pablogsal mentioned this pull request Jul 18, 2021
Closed
stratakis pushed a commit to stratakis/cpython that referenced this pull request Aug 5, 2021
@miss-islington @stratakis
bpo-40645: Fix ref leaks in _hashopenssl (pythonGH-26079)
6469768 
(cherry picked from commit 504ffda)

Co-authored-by: Erlend Egeberg Aasland <[email protected]>
encukou pushed a commit to encukou/cpython that referenced this pull request Sep 8, 2021
@tiran @pablogsal @encukou
bpo-40645: use C implementation of HMAC (pythonGH-24920, pythonGH-25063…
62debb2 
…, pythonGH-26079)

This backports the feature and 2 subsequent bugfixes
from: https://bugs.python.org/issue40645

Signed-off-by: Christian Heimes <[email protected]>
Co-authored-by: Erlend Egeberg Aasland <[email protected]>
Co-Authored-By: Pablo Galindo <[email protected]>
stratakis pushed a commit to stratakis/cpython that referenced this pull request Jan 18, 2022
@tiran @pablogsal @stratakis
bpo-40645: use C implementation of HMAC (pythonGH-24920, pythonGH-25063…
6b98f14 
…, pythonGH-26079)

This backports the feature and 2 subsequent bugfixes
from: https://bugs.python.org/issue40645

Signed-off-by: Christian Heimes <[email protected]>
Co-authored-by: Erlend Egeberg Aasland <[email protected]>
Co-Authored-By: Pablo Galindo <[email protected]>
stratakis pushed a commit to stratakis/cpython that referenced this pull request Jan 21, 2022
@tiran @pablogsal @stratakis
bpo-40645: use C implementation of HMAC (pythonGH-24920, pythonGH-25063…
d0903aa 
…, pythonGH-26079)

This backports the feature and 2 subsequent bugfixes
from: https://bugs.python.org/issue40645

Signed-off-by: Christian Heimes <[email protected]>
Co-authored-by: Erlend Egeberg Aasland <[email protected]>
Co-Authored-By: Pablo Galindo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pablogsal pablogsal pablogsal approved these changes

@tiran tiran Awaiting requested review from tiran

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@erlend-aasland @pablogsal @miss-islington @bedevere-bot @the-knights-who-say-ni