-
-
Notifications
You must be signed in to change notification settings - Fork 31.9k
gh-91632: Fix generic_alias_iterator to be finalized at exit. #91727
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
c7d5777
to
39886d9
Compare
I can't review this since I have no clue on the process of freeing memory on exit. But when do we add a type to |
I propose two approaches:
|
Misc/NEWS.d/next/Core and Builtins/2022-04-20-14-43-37.gh-issue-91632.cvUhsZ.rst
Outdated
Show resolved
Hide resolved
…e-91632.cvUhsZ.rst Co-authored-by: Victor Stinner <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Should this be backported? |
@JelleZijlstra No. Generic alias iterator is part of the variadic generics PEP which is 3.11 only iirc. |
The work to clear static types at exit is new in Python 3.11 (especially the _PyTypes_FiniTypes() function). |
AS-IS
TO-BE
Follow Victor's suggestion :)
closes: #91632