-
-
Notifications
You must be signed in to change notification settings - Fork 31.9k
GH-92955: fix memory leak in code object lines and positions iterators #92956
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vstinner @erlend-aasland
I am not sure that we need to handle all these cases,
or is it better to wait for approval for converting static types into heap types from SC
These are the last static types which are accessible from python which are not finalized by the interpreter exit in core objects ( Also IIUC Heap types should be only used in extension modules not for interpreter core objects. From PEP 687:
|
Just to be clear this PR has nothing to do with conversion of static types to heap types. This PR only fixes a memory leak as static type was not finalized and is now finalized like other static types. |
That's nice
I just asked about one of Victor's last suggestions. |
I am finishing off his work of adding all static types which need to be finalized at exit and these are the last ones left. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this will be the last change under Objects/*.c, I am happy to approve this change.
Thanks @corona10 |
Closes #92955