gh-95065: Add Argument Clinic support for deprecating positional use of parameters #95151
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Disclaimer: there's probably a lot of corner cases I haven't thought of yet. This is very much a draft. |
|
@zware, are you interested in reviewing this? This is probably quite crude, but my Argument Clinic knowledge is minimal, so I think getting a round of reviews is needed for me to move forward with this. |
|
cc. @arhadthedev, if you would like to review this. |
arhadthedev
previously approved these changes
Jul 26, 2022
erlend-aasland
dismissed
arhadthedev’s stale review
The feature is not ready yet; dismissing premature approval.
serhiy-storchaka
approved these changes
Aug 7, 2023
Thank you all so much for helping out with this PR. I learned some new tricks, and it was very good with some extra pairs of eyes on this. |
|
I improved the NEWS entry, but I also think we should promote this feature in What's New. I'm not sure where in What's New, though. |
serhiy-storchaka
approved these changes
Aug 7, 2023
Misc/NEWS.d/next/Tools-Demos/2022-07-23-00-33-28.gh-issue-95065.NfCCpp.rst
Outdated
Show resolved
Hide resolved
…5.NfCCpp.rst Co-authored-by: Serhiy Storchaka <[email protected]>
|
Thanks again. I'll wait for Alex's approval before landing. |
AlexWaygood
reviewed
Aug 7, 2023
AlexWaygood
reviewed
Aug 7, 2023
This reverts commit d2130ab, but keeps the test.
erlend-aasland
added a commit
to erlend-aasland/devguide
that referenced
this pull request
Sep 8, 2023
…of parameters (python/cpython#95151) It is now possible to deprecate passing parameters positionally with Argument Clinic, using the new '* [from X.Y]' syntax. (To be read as "keyword-only from Python version X.Y") Co-authored-by: Alex Waygood <[email protected]> Co-authored-by: Serhiy Storchaka <[email protected]>
AA-Turner
pushed a commit
to AA-Turner/devguide
that referenced
this pull request
Sep 13, 2023
…itional use of parameters (python/cpython#95151) It is now possible to deprecate passing parameters positionally with Argument Clinic, using the new '* [from X.Y]' syntax. (To be read as "keyword-only from Python version X.Y") Co-authored-by: Alex Waygood <[email protected]> Co-authored-by: Serhiy Storchaka <[email protected]>
erlend-aasland
added a commit
to python/devguide
that referenced
this pull request
Sep 26, 2023
…itional use of parameters (python/cpython#95151) It is now possible to deprecate passing parameters positionally with Argument Clinic, using the new '* [from X.Y]' syntax. (To be read as "keyword-only from Python version X.Y") Co-authored-by: Alex Waygood <[email protected]> Co-authored-by: Serhiy Storchaka <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for deprecating positional use of optional parameters by
introducing the
* [from X.Y]syntax, meaning the following parameterswill be keyword-only starting with Python version X.Y. Code that emits
DeprecationWarnings and compile time messages will be automatically
generated.
Multiple
* [from X.Y]lines are not allowed (yet).