-
-
Notifications
You must be signed in to change notification settings - Fork 32.1k
gh-95065: Add Argument Clinic support for deprecating positional use of parameters #95151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 91 commits
Commits
Show all changes
95 commits
Select commit
Hold shift + click to select a range
9196162
PoC
erlend-aasland 6a8c14f
Add tests
erlend-aasland 457d38a
Improve warning wording
erlend-aasland 3687748
Add NEWS
erlend-aasland 9c81ae1
Pull in main
erlend-aasland a5734d6
Pull in main
erlend-aasland 1e9fd55
Pull in main
erlend-aasland 93e0745
Merge branch 'main' into ac-deprecate
erlend-aasland 6bde63d
Add annotation
erlend-aasland bb619a5
Pull in main
erlend-aasland d85475e
Amend tests
erlend-aasland 68f8ed9
Pull in main
erlend-aasland ca496b4
Amend test
erlend-aasland fe77d5f
Annotate
erlend-aasland de9e661
Pull in main
erlend-aasland 3701b41
Fix merge
erlend-aasland a149a7b
Fix tests and repr
erlend-aasland e9ad211
Get ready for '* [from ...]' syntax
erlend-aasland 0fcad58
Add 'whence' to deprecation warning message
erlend-aasland efb1fba
PoC
erlend-aasland 3d8164f
Pull in main
erlend-aasland 43cec6c
Improve preprocessor warning message, and fix it on windows
erlend-aasland 075cf67
Nits
erlend-aasland 13104e8
Assert format
erlend-aasland dc22c91
Pull in main
erlend-aasland 7864dcb
Improve accuracy of variable name
erlend-aasland fbed52f
Add docs
erlend-aasland 222c3bb
Pull in main
erlend-aasland 2abe7a3
Adjust CPP barking
erlend-aasland 4c0ec79
Fix CPP
erlend-aasland 35fbe80
Fix CPP for error case also
erlend-aasland ccf8df8
Update clinic.test.c
erlend-aasland 4db3c8d
Fix and test multiple deprecation directives error message
erlend-aasland 43af475
Extend the docs
erlend-aasland 5074495
Add note about compiler error
erlend-aasland ce5cd92
Fixup docs and fixup cpp error string
erlend-aasland c2cfc80
Pull in main
erlend-aasland 4dc8241
Fix mypy complain
erlend-aasland b2c8f34
Pull in main
erlend-aasland 5f181c7
Pull in main
erlend-aasland 9eab8f7
Address review: annotate deprecated_positional as str | None
AlexWaygood 25aa23c
Address review: add return annotation to parse_deprecated_positional()
erlend-aasland 6624e8f
Merge branch 'main' into ac-deprecate
erlend-aasland 46924a7
Pull in main
erlend-aasland 2e72b66
WIP
erlend-aasland cbbcf1a
Pull in main
erlend-aasland f82be40
Pull in main
erlend-aasland a76d63c
Move prototype to class level
erlend-aasland e5bbd7b
Address review: start warning from alpha stage
erlend-aasland c981efa
Add more test cases
erlend-aasland 821124e
Add TODO comment
erlend-aasland aa1b85d
Test case 2 already covers this test case
erlend-aasland 44af850
Handle more cases
erlend-aasland 01f17f9
Add one more test case as requested by Nikita
erlend-aasland e6860bc
Fix mypy whining
erlend-aasland 71a8750
Address Alex's review: solve mypy complaint more elegantly
erlend-aasland e6886f0
Address some of Serhiy's remarks:
erlend-aasland 480a29f
Address review: use stack level 1
erlend-aasland a3cf43a
Merge branch 'main' into ac-deprecate
erlend-aasland 5151e62
Pull in main
erlend-aasland b98aab3
Address Serhiy's second round of remarks:
erlend-aasland eeb8187
Fix merge: revert accidental removal of a clinic.test.c test method
erlend-aasland 6c6dd10
Address Alex and Serhiy's doc remarks
erlend-aasland ddd319b
Pull in main
erlend-aasland 47a8979
Further improvements:
erlend-aasland 02eba96
Make mypy happy (quickfix)
erlend-aasland fa77489
Revert sqlite3 test
erlend-aasland 87a7f20
Use try...except ValueError trick for neater code
erlend-aasland f36bc05
Move VersionTuple to above Parameter class
erlend-aasland 5e65020
Add more tests for illegal formats
erlend-aasland f1f311a
Don't link to keyword-only param glossary section
erlend-aasland 83de0b8
No need for iter
erlend-aasland b10dc9c
For now, only use the basename of the source file
erlend-aasland c4ba025
Apply suggestions from code review
erlend-aasland c875d60
Fix mypy error
erlend-aasland cdd927c
Fix deprecation condition
erlend-aasland f0847bc
Further improve warning messages
erlend-aasland ce8db9a
Simplify condition
erlend-aasland 0dff20c
Merge remote-tracking branch 'origin/ac-deprecate' into ac-deprecate
erlend-aasland b45d845
Refactor: extract pprinter
erlend-aasland d2330c6
Reintroduce condition and fixup deprecation message
erlend-aasland 622b556
Remove unused variable, and reorder some lines for readability
erlend-aasland e71fbe1
Simplify pprint_words
erlend-aasland c4141f0
Fix function name formatting
erlend-aasland 87e50c7
Use fully qualified function/meth name in fail() messages
erlend-aasland 6e9e7b4
Add more test cases and normalise the their naming
erlend-aasland bde0f90
Improve deprecation messages
erlend-aasland 8e9ea05
Pull in main
erlend-aasland 8324510
ValueError will catch if '.' not in thenceforth for us
erlend-aasland 2e4d64f
Improve NEWS entry
erlend-aasland 52e7078
Update Misc/NEWS.d/next/Tools-Demos/2022-07-23-00-33-28.gh-issue-9506…
erlend-aasland 8a39ffb
Fix grammar in depr sentence
erlend-aasland dc8f10d
Merge remote-tracking branch 'origin/ac-deprecate' into ac-deprecate
erlend-aasland d2130ab
Fix fixup code and add test
erlend-aasland b21bc32
Revert "Fix fixup code and add test"
erlend-aasland File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.