Skip to content

gh-96175: add missing self._localName assignment in xml.dom.minidom.Attr #96176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Aug 23, 2022
Merged

gh-96175: add missing self._localName assignment in xml.dom.minidom.Attr #96176

merged 10 commits into from
Aug 23, 2022
+18 −1

Conversation

kkirsche
Copy link
Contributor

@kkirsche kkirsche commented Aug 22, 2022 •
edited
Loading

Fixes: #96175

X-Ref: python/typeshed#8590 (comment)

This adds a missing assignment to _localName

@bedevere-bot
Copy link

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.

@ghost
Copy link

ghost commented Aug 22, 2022 •
edited by ghost
Loading

All commit authors signed the Contributor License Agreement.
CLA signed

@kkirsche
Copy link
Contributor Author

CLA stuff is borked:

CleanShot 2022-08-22 at 10 28 10@2x

@kkirsche kkirsche mentioned this pull request Aug 22, 2022
Merged
@JelleZijlstra
Copy link
Member

Thank you!

cc @ambv for the CLA bot throwing a 500.

Could you add a unit test and a NEWS entry? You can use blurb as documented under 8 at https://devguide.python.org/?highlight=blurb#quick-reference.

@JelleZijlstra JelleZijlstra self-assigned this Aug 22, 2022
@JelleZijlstra JelleZijlstra added needs backport to 3.10 only security fixes needs backport to 3.11 only security fixes labels Aug 22, 2022
@kkirsche
Copy link
Contributor Author

Could you add a unit test and a NEWS entry? You can use blurb as documented under 8 at https://devguide.python.org/?highlight=blurb#quick-reference.

I'll give it my best shot, I have that cloning so I can add those in after my next meeting this afternoon. Thanks for the opportunity to contribute this to cpython, it's a project where the must have an issue requirement in the contributing guide has kept me away in the past.

@bedevere-bot
Copy link

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.

1 similar comment
@bedevere-bot
Copy link

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.

@kkirsche
Copy link
Contributor Author

I've added my attempt at this. If I did anything incorrectly or without enough detail, please let me know.

It may also be useful to give an example in blurb about what a good paragraph would look like.

@kkirsche
Copy link
Contributor Author

kkirsche commented Aug 22, 2022 •
edited
Loading

I have tried to sign the CLA, but have been unable to. Sometimes it shows up as signed, other times it doesn't, so wanted to comment here explicitly.

@JelleZijlstra
Copy link
Member

The CLA actually seems fine, the check in CI is succeeding.

JelleZijlstra
JelleZijlstra reviewed Aug 23, 2022
View reviewed changes
@JelleZijlstra JelleZijlstra merged commit 58f6953 into python:main Aug 23, 2022
@miss-islington
Copy link
Contributor

Thanks @kkirsche for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry @kkirsche and @JelleZijlstra, I had trouble checking out the 3.11 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 58f6953d6d3fe20d972bfa2f6e982206adcf1353 3.11

@JelleZijlstra
Copy link
Member

Thank you for your contribution!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 23, 2022
@kkirsche @miss-islington
pythongh-96175: add missing self._localName assignment in `xml.dom.mi…
75e16ef 
…nidom.Attr` (pythonGH-96176)

X-Ref: https://github.com/python/typeshed/pull/8590GH-discussion_r951473977

Co-authored-by: Jelle Zijlstra <[email protected]>
(cherry picked from commit 58f6953)

Co-authored-by: Kevin Kirsche <[email protected]>
@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Aug 23, 2022
@bedevere-bot
Copy link

GH-96212 is a backport of this pull request to the 3.10 branch.

@JelleZijlstra JelleZijlstra added needs backport to 3.11 only security fixes and removed needs backport to 3.11 only security fixes labels Aug 23, 2022
@miss-islington
Copy link
Contributor

Thanks @kkirsche for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Aug 23, 2022
@bedevere-bot
Copy link

GH-96213 is a backport of this pull request to the 3.11 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 23, 2022
@kkirsche @miss-islington
pythongh-96175: add missing self._localName assignment in `xml.dom.mi…
b3d9308 
…nidom.Attr` (pythonGH-96176)

X-Ref: https://github.com/python/typeshed/pull/8590GH-discussion_r951473977

Co-authored-by: Jelle Zijlstra <[email protected]>
(cherry picked from commit 58f6953)

Co-authored-by: Kevin Kirsche <[email protected]>
miss-islington added a commit that referenced this pull request Aug 23, 2022
@miss-islington @kkirsche
gh-96175: add missing self._localName assignment in `xml.dom.minidom.…
e783a23 
…Attr` (GH-96176)

X-Ref: https://github.com/python/typeshed/pull/8590GH-discussion_r951473977

Co-authored-by: Jelle Zijlstra <[email protected]>
(cherry picked from commit 58f6953)

Co-authored-by: Kevin Kirsche <[email protected]>
@kkirsche
Copy link
Contributor Author

Thank you for your contribution!

Thank you for your time reviewing this and your patience explaining why decisions are being made as I learn more about CPython.

miss-islington added a commit that referenced this pull request Aug 23, 2022
@miss-islington @kkirsche
gh-96175: add missing self._localName assignment in `xml.dom.minidom.…
d7eea0f 
…Attr` (GH-96176)

X-Ref: https://github.com/python/typeshed/pull/8590GH-discussion_r951473977

Co-authored-by: Jelle Zijlstra <[email protected]>
(cherry picked from commit 58f6953)

Co-authored-by: Kevin Kirsche <[email protected]>
@kkirsche kkirsche deleted the patch-2 branch August 23, 2022 18:25
mdboom pushed a commit to mdboom/cpython that referenced this pull request Aug 24, 2022
@kkirsche @JelleZijlstra @mdboom
pythongh-96175: add missing self._localName assignment in `xml.dom.mi…
77c8ccc 
…nidom.Attr` (python#96176)

X-Ref: python/typeshed#8590 (comment)

Co-authored-by: Jelle Zijlstra <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes

Assignees

@JelleZijlstra JelleZijlstra

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

xml.dom.minidom:Attr.__init__ doesn't use localName variable.
4 participants
@kkirsche @bedevere-bot @JelleZijlstra @miss-islington