[3.11] gh-96175: add missing self._localName assignment in xml.dom.minidom.Attr (GH-96176)
#96213
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nidom.Attr` (pythonGH-96176) X-Ref: https://github.com/python/typeshed/pull/8590GH-discussion_r951473977 Co-authored-by: Jelle Zijlstra <[email protected]> (cherry picked from commit 58f6953) Co-authored-by: Kevin Kirsche <[email protected]>
|
Status check is done, and it's a success ✅ . |
|
@pablogsal this is a simple bugfix that I'd like to go into 3.11 eventually. I'm happy to wait until after the RC phase though. |
pablogsal
approved these changes
Aug 23, 2022
|
Ok, makes sense, let's get it merged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
X-Ref: https://github.com/python/typeshed/pull/8590GH-discussion_r951473977
Co-authored-by: Jelle Zijlstra [email protected]
(cherry picked from commit 58f6953)
Co-authored-by: Kevin Kirsche [email protected]
xml.dom.minidom:Attr.__init__doesn't use localName variable. #96175